test(EndToEnd): Add "Flame graph" tests #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # e2e/fixtures/pages/ExploreProfilesPage.ts # e2e/tests/all-services-view/all-services.spec.ts # e2e/tests/explore-profiles/explore-profiles.spec.ts # e2e/tests/profile-types-view/profile-types.spec.ts
Unit test coverage
|
This was referenced Aug 28, 2024
grafakus
commented
Aug 28, 2024
| urlParams.set('explorationType', explorationType); | ||
|
|
||
| return super.goto(urlParams.toString()); | ||
| } | ||
|
|
||
| /* Data source */ |
There was a problem hiding this comment.
In a future PR, we should split the responsibilities among several, smaller classes.
grafakus
commented
Aug 29, 2024
| @@ -1,6 +1,6 @@ | |||
| import { expect, test } from '../../fixtures'; | |||
|
|
|||
| test.describe('Smoke tests', () => { | |||
| test.describe.skip('Smoke tests', () => { | |||
There was a problem hiding this comment.
Skipping for now, we will remove them in #143
grafakus
commented
Aug 29, 2024
| > | ||
| {children} | ||
| <div id="icon-new" className={styles.sup}> |
There was a problem hiding this comment.
The feature was deployed some months ago already so we can safely remove the "new" badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s): resolves #133, is blocked by #135
📖 Summary of the changes
See diff tab for specific comments.
🧪 How to test?