Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant operation when modifying shared properties of multiple select nodes if expected modification value is the current value of the first node #104467

Open
MadeScientist opened this issue Mar 22, 2025 · 2 comments

Comments

@MadeScientist
Copy link

MadeScientist commented Mar 22, 2025

Tested versions

  • Reproducible in: 4.5dev1

System information

Godot v4.5.dev1 - Windows 10 (build 19045) - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 32.0.15.6603) - Intel(R) Core(TM) i5-6300HQ CPU @ 2.30GHz (4 threads)

Issue description

I'm not sure if the title accurately described the problem, so here I will provide more details for the specific behavior. I think the core problem lies in the fact that when editing a property of a node without changing default value and then pressing enter key to confirm, does it need to update the node's property or not.

When editing a single node, this is not a problem. But when editing multiple nodes simultaneously, if the current value of the first selected node is the value I want to modify for all selected nodes, i need to firstly modify value of first node to something else and then modify it back to the previous value that what i mean redundant operation. The behavior similar to export enumeration described in #74123, #102711(before #102743 fixed them).

The expected behavior should be that when editing multiple select nodes, any modifications to their shared properties(displayed as the property of the first node) will simultaneously affect all selected nodes.

Demonstration:

multiple_select.mp4

Steps to reproduce

N/A

Minimal reproduction project (MRP)

N/A

@Rindbee
Copy link
Contributor

Rindbee commented Mar 22, 2025

This is not true for all types of properties, this only applies to properties with multiple fields (Vector2, Vector3, etc. types). And there is no problem copying and pasting using shortcut keys (on the property).

@MadeScientist
Copy link
Author

This is not true for all types of properties, this only applies to properties with multiple fields (Vector2, Vector3, etc. types). And there is no problem copying and pasting using shortcut keys (on the property).

Enumeration properties have same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants