Assign the project manager title to the node instead of DisplayServer #100745
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of DisplayServer
AThousandShips
changed the title
timothyqiu
requested changes
Dec 23, 2024
There was a problem hiding this comment.
The title is now Godot Engine - Project Manager (DEBUG).
The main window's title always has this (DEBUG) suffix for debug builds. The same goes for official builds too since debugging features are enabled when compiling the editor.
I think that's why the title was set on DisplayServer instead of Window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100727
Project Manager title is directly given to the
DisplayServerat initialization.With the changes of ff6eea5 auto-translation triggers the renaming of the window and leading to the bug since the
titleattribute of the scene root was not defined.This fix gives the title to the root of the
SceneTreewhich solves the problem.