Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class_name doc comments edited with external editor don't update until editor restart #100704

Open
idbrii opened this issue Dec 21, 2024 · 1 comment

Comments

@idbrii
Copy link
Contributor

idbrii commented Dec 21, 2024

Tested versions

Reproducible in v4.3.stable.official [77dcf97]

Class doc comments were added in d1231be, but I haven't checked if it occurred in that build.

System information

Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 32.0.15.6590) - Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 Threads)

Issue description

When you use an external editor to modify a class_name doc comment, the old value is still displayed (in Create New Node) until you restart Godot.

I have auto reload scripts enabled:
Image

Steps to reproduce

  1. Enable external editor (I use vim).
  2. Existing script nilrotation.gd:
## Sometimes you don't want rotation to change.
class_name NilRotation
extends Node2D


func _process(_dt):
    global_rotation = 0
  1. Confirm Create New Node shows the correct docstring
    missing the first line

  2. In external editor, change the line to ## Force the global rotation to stay at 0 (never rotate).

  3. Check docstring shown in Create New Node.

Expected: It's updated.
Actual: It hasn't changed.

Minimal reproduction project (MRP)

trivially reproducible in new project.

@miv391
Copy link
Contributor

miv391 commented Dec 21, 2024

I tested this with v4.4.dev7.mono.official [46c8f8c5c] but I cannot reproduce the problem. I used vscode (with language server connection) and Windows' notepad (no language server connection). Class comment updated in Godot Editor as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants