Remove unused editor setting editors/grid_map/editor_side
#100702
+0
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The setting should also be removed from Note that doing this will not clear the editor setting from the configuration of every user. The setting will still exist when a returning user opens the editor, but it cannot be cleared and will have no description anymore. As far as the editor will be concerned, that setting may be coming from a plugin. |
AThousandShips
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Looks removed in the linked PR indeed, can you confirm @Nodragem?
Needs indeed removing the entry from the documentation
As this is completely irrelevant now we don't need any compatibility code
Mickeon
approved these changes
Dec 21, 2024
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
This option is no longer used after the rework in godotengineGH-96922
spoxii
force-pushed
the
patch/unused_gridmap_editor_side
branch
from
56d04f2 to
143e10e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100699.
The editor setting
editors/grid_map/editor_sideis no longer used after the rework in GH-96922 and can be removed.