You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, if someone uses textures with different sizes, they will be surprised that size is not selected as maximum among all "layers".
For example, this is how it looks inside GridContainer:
And this is how it will look if we change minimum size calculation from proprity-based to maximum among all "layers":
Of course, it could be solved by enabling nine-patch stretching with zero margins and setting a custom minimum size. And, of course, if no one even reported it before, perhaps no one needs this change.
BUT if changing from priority-based approach to maximum is welcomed, I'll open PR to fix it. I'm sure that "maximum among all layers" is proper behaviour.
Steps to reproduce
Create TextureProgressBar and assign to it textures with different sizes.
Minimal reproduction project (MRP)
New Game Project.zip
Actually this one is my playground to test different TextureProgressBar issues.
The text was updated successfully, but these errors were encountered:
Tested versions
Reproducible since Godot was opensourced.
System information
Not specific to hardware.
Issue description
As title says,
TextureProgressBar
minimal size is prioritized tounder
->over
->progress
textures:So, if someone uses textures with different sizes, they will be surprised that size is not selected as maximum among all "layers".
For example, this is how it looks inside
GridContainer
:And this is how it will look if we change minimum size calculation from proprity-based to maximum among all "layers":
To fix it I changed function to the following:
Of course, it could be solved by enabling nine-patch stretching with zero margins and setting a custom minimum size. And, of course, if no one even reported it before, perhaps no one needs this change.
BUT if changing from priority-based approach to maximum is welcomed, I'll open PR to fix it. I'm sure that "maximum among all layers" is proper behaviour.
Steps to reproduce
Create
TextureProgressBar
and assign to it textures with different sizes.Minimal reproduction project (MRP)
New Game Project.zip
Actually this one is my playground to test different
TextureProgressBar
issues.The text was updated successfully, but these errors were encountered: