Skip to content

Conversation

@shameekganguly
Copy link
Contributor

🦟 Bug fix

Summary

Few small fixes in MODULE.bazel as pre-work to add automation to push new releases to BCR.

  • Remove archive_override for gz-utils and gz-math deps and used Jetty packages from BCR instead. As a result, bazel CI will use released versions of gz deps, which is consistent with cmake CI.
  • Drop repo_name, which removes the need to patch MODULE.bazel when pushing a release to BCR. repo_name is not a required field and can be added on the client side during import if needed to disambiguate packages.
  • Add compatibility_level to match what is set in BCR
  • Bump buildifier_prebuilt since version 8.2.0 has a bug in bazel 8 presubmits. Also remove unnecessary buildifier targets in test/BUILD.bazel; the top-level targets in BUILD.bazel cover the whole repo.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Shameek Ganguly <[email protected]>
@shameekganguly
Copy link
Contributor Author

Note: this PR cannot be forward-ported to main automatically since we still want the archive_overrides in MODULE.bazel on that branch. I will open a manual forward port PR once this is merged.

Signed-off-by: Shameek Ganguly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants