-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ruby script to use standalone executable #1489
base: scpeters/gz_sdf_executable
Are you sure you want to change the base?
Updating ruby script to use standalone executable #1489
Conversation
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
2be0d2d
to
615048c
Compare
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@sauk2 have you had a chance to push this further? |
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
src/gz_TEST.cc
Outdated
{ | ||
return " --force-version " + std::string(SDF_VERSION_FULL); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for removing this? The --foce-version
argument is handled by gz-tools
(see https://github.com/gazebosim/gz-tools/blob/2b228e5b956f1e966053dd860374670573580b41/src/gz.in#L244). We need to make sure it still works with the change to using executables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I added it back and the tests should pass now!
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
--inertial-stats | ||
-h --help | ||
--force-version | ||
--versions | ||
-v --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following test failed when --force-version
and --versions
were kept in.
Lines 2071 to 2073 in 181c0ef
/// \brief Check help message and bash completion script for consistent flags | |
TEST(HelpVsCompletionFlags, GZ_UTILS_TEST_DISABLED_ON_WIN32(SDF)) | |
{ |
I noticed those tags were removed in bash_completion
of gz-transport
so I did the same here. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I think we'll need to keep it here. Otherwise, it would not show up in the bash completions. I think it'd be better to modify the HelpVsCompletionFlags
test to make it pass in this case.
Signed-off-by: Saurabh Kamat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the --force-versions
issue, it LGTM!
--inertial-stats | ||
-h --help | ||
--force-version | ||
--versions | ||
-v --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I think we'll need to keep it here. Otherwise, it would not show up in the bash completions. I think it'd be better to modify the HelpVsCompletionFlags
test to make it pass in this case.
🎉 New feature
Related to gazebosim/gz-tools#7
Summary
Updated the ruby script to use the standalone executable.
I also tried to resolve the issue of building the package because of the
FrameSemantics
class. You can check the error in ci of your branch.I updated the CMakeLists and am not sure if the following is the right approach ...
Test it
Test any of the SDF commands
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.