-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off application tests CI #16
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -15,9 +15,10 @@ on: | |||
required: true | ||||
PAT: | ||||
required: true | ||||
on: | ||||
pull_request_review: | ||||
types: [ submitted, edited ] | ||||
push: | ||||
branches: [ "master" ] | ||||
pull_request: | ||||
branches: [ "master" ] | ||||
|
||||
env: | ||||
CARGO_TERM_COLOR: always | ||||
|
@@ -26,7 +27,7 @@ jobs: | |||
build: | ||||
|
||||
runs-on: ubuntu-20.04 | ||||
if: github.event_name == 'pull_request' && github.event.review.state == 'approved' | ||||
|
||||
steps: | ||||
- name: Pull main repository | ||||
uses: actions/checkout@v3 | ||||
|
@@ -72,12 +73,6 @@ jobs: | |||
# Download the latest release of docker-credential-ecr-login | ||||
aws s3 cp s3://fortanix-internal-artifact-repository/other-packages/docker-credential-ecr-login . | ||||
|
||||
# Make it executable | ||||
chmod +x docker-credential-ecr-login | ||||
|
||||
# Move it to a directory in the PATH | ||||
sudo mv docker-credential-ecr-login /usr/local/bin/ | ||||
|
||||
- name: Build Rust code | ||||
run: | | ||||
./build-converter.sh | ||||
|
@@ -89,13 +84,14 @@ jobs: | |||
run: | | ||||
./unit-test-solution.sh | ||||
|
||||
- name: Build application tests container | ||||
run: | | ||||
./build-app-tests-container.sh | ||||
|
||||
- name: Run application tests container | ||||
env: | ||||
FORTANIX_API_KEY: ${{ secrets.FORTANIX_API_KEY }} | ||||
OVERLAYFS_UNIT_TEST_API_KEY: ${{ secrets.OVERLAYFS_UNIT_TEST_API_KEY }} | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now these keys are no longer required, right? Can you also remove them from the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are still used in
|
||||
run: | | ||||
./run-application-tests.sh ${{ env.TESTS_CONTAINER_ECR }} ${{ env.FORTANIX_API_KEY }} | ||||
# Will be uncommented in RTE-188 | ||||
# - name: Build application tests container | ||||
nshyrei marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
# run: | | ||||
# ./build-app-tests-container.sh | ||||
|
||||
# - name: Run application tests container | ||||
# env: | ||||
# FORTANIX_API_KEY: ${{ secrets.FORTANIX_API_KEY }} | ||||
# OVERLAYFS_UNIT_TEST_API_KEY: ${{ secrets.OVERLAYFS_UNIT_TEST_API_KEY }} | ||||
# run: | | ||||
# ./run-application-tests.sh ${{ env.TESTS_CONTAINER_ECR }} ${{ env.FORTANIX_API_KEY }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Personally I'm in strong favor of a one-goal-one-PR rule. It makes it much more clear why these changes are there. I agree to what you're trying to do, but doesn't that mean we can also disable the other keys here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand what keys are you talking about here, do you want to remove the
push/pull
rules? I believe in that case CI won't start.