- code review changes

fortanix · Oct 4, 2024 · af3ad67 · af3ad67
1 parent bcbdc7e
commit af3ad67
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/build-solution.yml b/.github/workflows/build-solution.yml
@@ -68,8 +68,10 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libpcap-dev amazon-ecr-credential-helper
 
-          # Setup docker-credential-ecr-login
-          sudo mv /usr/bin/docker-credential-ecr-login /usr/local/bin/
+      - name: Install docker-credential-ecr-login
+        run: |
+          # Download the latest release of docker-credential-ecr-login
+          aws s3 cp s3://fortanix-internal-artifact-repository/other-packages/docker-credential-ecr-login .
 
       - name: Build Rust code
         run: |

diff --git a/make/salmiac-tests-container.make b/make/salmiac-tests-container.make
@@ -127,4 +127,4 @@ $(TESTS-CONTAINER): $(TESTS-STAGE-CONTENTS)
 
 $(TESTS-CONTAINER-APP-TESTS-FILE)::    | $(dir $(TESTS-CONTAINER-APP-TESTS-FILE))
 
-$(eval $(call make-cp-rule,/usr/local/bin/$(DOCKER-AWS-HELPER),$(TESTS-STAGE-DIR)/$(DOCKER-AWS-HELPER)))
+$(eval $(call make-cp-rule,/usr/bin/$(DOCKER-AWS-HELPER),$(TESTS-STAGE-DIR)/$(DOCKER-AWS-HELPER)))
Original file line number	Diff line number	Diff line change
Expand Up		@@ -127,4 +127,4 @@ $(TESTS-CONTAINER): $(TESTS-STAGE-CONTENTS)

		$(TESTS-CONTAINER-APP-TESTS-FILE):: \| $(dir $(TESTS-CONTAINER-APP-TESTS-FILE))

		$(eval $(call make-cp-rule,/usr/local/bin/$(DOCKER-AWS-HELPER),$(TESTS-STAGE-DIR)/$(DOCKER-AWS-HELPER)))
		$(eval $(call make-cp-rule,/usr/bin/$(DOCKER-AWS-HELPER),$(TESTS-STAGE-DIR)/$(DOCKER-AWS-HELPER)))