Turn off application tests CI #16
Conversation
|
Why is the branch named SALM-213? Can we rename the branch to the relevant ticket? |
This is the correct ticket number - "Turn off Application tests in Salmiac" |
It's RTE-213 and not SALM-213 |
| - name: Run application tests container | ||
| env: | ||
| FORTANIX_API_KEY: ${{ secrets.FORTANIX_API_KEY }} | ||
| OVERLAYFS_UNIT_TEST_API_KEY: ${{ secrets.OVERLAYFS_UNIT_TEST_API_KEY }} |
There was a problem hiding this comment.
Now these keys are no longer required, right? Can you also remove them from the secrets section above?
There was a problem hiding this comment.
They are still used in
| push: | ||
| branches: [ "master" ] | ||
| pull_request: | ||
| branches: [ "master" ] |
There was a problem hiding this comment.
Nitpick: Personally I'm in strong favor of a one-goal-one-PR rule. It makes it much more clear why these changes are there. I agree to what you're trying to do, but doesn't that mean we can also disable the other keys here?
There was a problem hiding this comment.
I don't fully understand what keys are you talking about here, do you want to remove the push/pull rules? I believe in that case CI won't start.
This PR turns off application tests CI until we move test images into a public repository. Additionally the PR contains the following small additions:
project build + unit testsdocker-credential-ecr-loginis now downloaded from a public place instead of a private one