fix: "Fetch metadata" is skipped for "pull_request_target" #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The step `Fetch metadata` is skipped for a workflow triggered by the `pull_request_target`. The issue was found the first time approximately on the 28th of August. Before the date, there was no issue with the same workflow file. It seems something has been changed in GitHub Workflow implementation, but I couldn't find any evidence.
`dependabot-auto-merge.yml` content:
```
name: Dependabot
on: pull_request_target
permissions:
contents: write
pull-requests: write
jobs:
Auto-merge:
runs-on: ubuntu-latest
steps:
- uses: fastify/github-action-merge-dependabot@v3
with:
use-github-auto-merge: true
target: minor
```
kirillsud
added a commit
to miroapp/api-clients
that referenced
this pull request
Sep 7, 2023
`fastify/github-action-merge-dependabot` filters out PRs triggered not by `pull_request` event. After creating a ticket to the action repo, developers answered me that probably there is no need to use `pull_request_target`: fastify/github-action-merge-dependabot#474 (review).
kirillsud
added a commit
to miroapp/api-clients
that referenced
this pull request
Sep 7, 2023
`fastify/github-action-merge-dependabot` filters out PRs triggered not by `pull_request` event. After creating a ticket to the action repo, developers answered me that probably there is no need to use `pull_request_target`: fastify/github-action-merge-dependabot#474 (review). And it seems we don't: the workflow is targeted on dependabot PRs only, which are internal (not from forked repos), so for the `pull_request` event the workflow will have all required write permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The step
Fetch metadatais skipped for a workflow triggered by thepull_request_target. The issue was found the first time approximately on the 28th of August. Before the date, there was no issue with the same workflow file. It seems something has been changed in GitHub Workflow implementation, but I couldn't find any evidence.dependabot-auto-merge.ymlcontent:Fixes #475.
Checklist
npm run testandnpm run benchmarkand the Code of conduct