Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot auto-merge #245

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix dependabot auto-merge #245

merged 1 commit into from
Sep 7, 2023

Conversation

kirillsud
Copy link
Contributor

fastify/github-action-merge-dependabot filters out PRs triggered not by pull_request event. After creating a ticket to the action repo, developers answered me that probably there is no need to use pull_request_target: fastify/github-action-merge-dependabot#474 (review).

And it seems we don't: the workflow is targeted on dependabot PRs only, which are internal (not from forked repos), so for the pull_request event the workflow will have all required write permissions.

`fastify/github-action-merge-dependabot` filters out PRs triggered not by `pull_request` event. After creating a ticket to the action repo, developers answered me that probably there is no need to use `pull_request_target`: fastify/github-action-merge-dependabot#474 (review).
@kirillsud kirillsud requested a review from a team as a code owner September 7, 2023 09:41
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Coverage report for commit: 8f67721
File: packages/miro-api/coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.4%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.8%
  60% │ ██░░░░░░░░░░░░░░░░░░░░░ │  2.3%
  70% │ ███░░░░░░░░░░░░░░░░░░░░ │  5.3%
  80% │ ████████████████░░░░░░░ │ 32.3%
  90% │ ███████████████████████ │ 48.1%
 100% │ ██████░░░░░░░░░░░░░░░░░ │ 10.9%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 74.12% | Methods: 73.19% | Branches: 50.17%
FilesLinesMethodsBranches
packages/miro-api
   api.ts100.00%100.00%84.62%
   index.ts71.93%40.91%83.56%
   storage.ts100.00%100.00%66.67%
packages/miro-api/api
   apis.ts2.85%7.20%1.30%
packages/miro-api/highlevel
   Api.ts72.41%85.71%47.62%
   AppCardItem.ts100.00%100.00%73.33%
   Board.ts52.00%53.33%25.40%
   CardItem.ts100.00%100.00%73.33%
   DocumentItem.ts80.56%88.89%64.71%
   EmbedItem.ts100.00%100.00%73.33%
   FrameItem.ts78.13%100.00%36.00%
   ImageItem.ts80.56%88.89%64.71%
   Item.ts100.00%100.00%83.33%
   Organization.ts64.52%71.43%42.11%
   ShapeItem.ts100.00%100.00%73.33%
   StickyNoteItem.ts100.00%100.00%73.33%
   Tag.ts96.55%100.00%63.16%
   Team.ts56.76%71.43%34.78%
   TextItem.ts100.00%100.00%73.33%
   helpers.ts91.67%75.00%66.67%
   index.ts49.29%26.47%52.38%
packages/miro-api/model
   addProjectMemberRequest.ts89.66%77.78%66.67%
   appCardCreateRequest.ts81.25%77.78%66.67%
   appCardData.ts84.85%80.00%64.71%
   appCardDataChanges.ts84.85%80.00%64.71%
   appCardDataPlatformTags.ts82.35%80.00%64.71%
   appCardDataResponse.ts82.35%80.00%64.71%
   appCardItem.ts97.44%88.89%66.67%
   appCardStyle.ts92.86%77.78%66.67%
   appCardStylePlatformBulkCreateOperationExperimentalRelease.ts92.86%77.78%66.67%
   appCardUpdateRequest.ts81.25%77.78%66.67%
   basicError.ts83.87%77.78%66.67%
   basicErrorBoardExportJobEnterprisePlan.ts83.87%77.78%66.67%
   basicErrorOrganizationsEnterprisePlan.ts83.87%77.78%66.67%
   board.ts97.62%88.89%66.67%
   boardChanges.ts81.25%77.78%66.67%
   boardDataClassificationLabel.ts78.79%77.78%66.67%
   boardExportJobId.ts92.86%77.78%66.67%
   boardExportJobStatus.ts92.86%77.78%66.67%
   boardExportResult.ts89.66%77.78%66.67%
   boardExportTaskResult.ts83.87%77.78%66.67%
   boardLinks.ts89.66%77.78%66.67%
   boardMember.ts96.97%90.00%64.71%
   boardMemberChanges.ts93.33%80.00%64.71%
   boardMemberWithLinks.ts82.35%80.00%64.71%
   boardMembersInvite.ts87.50%80.00%64.71%
   boardMembersPagedResponse.ts76.47%77.78%66.67%
   boardPermissionsPolicy.ts88.24%80.00%64.71%
   boardPolicy.ts89.66%77.78%66.67%
   boardPolicyChange.ts89.66%77.78%66.67%
   boardSharingPolicy.ts86.11%80.00%64.71%
   boardSharingPolicyChange.ts86.11%80.00%64.71%
   boardSubscription.ts77.78%80.00%64.71%
   boardSubscriptionData.ts92.86%77.78%66.67%
   boardWithLinks.ts60.47%77.78%66.67%
   boardWithLinksAndWithoutProject.ts61.90%77.78%66.67%
   boardsPagedResponse.ts76.47%77.78%66.67%
   bulkOperationError.ts81.25%77.78%66.67%
   bulkOperationErrorContext.ts92.86%77.78%66.67%
   bulkSubOperationError.ts86.67%77.78%66.67%
   caption.ts87.50%80.00%64.71%
   cardCreateRequest.ts81.25%77.78%66.67%
   cardData.ts83.87%77.78%66.67%
   cardItem.ts97.44%88.89%66.67%
   cardStyle.ts92.86%77.78%66.67%
   cardStylePlatformBulkCreateOperationExperimentalRelease.ts92.86%77.78%66.67%
   cardUpdateRequest.ts81.25%77.78%66.67%
   connectorChangesData.ts82.35%80.00%64.71%
   connectorCreationData.ts82.35%80.00%64.71%
   connectorStyle.ts77.50%80.00%64.71%
   connectorWithLinks.ts97.62%90.00%64.71%
   connectorsCursorPaged.ts78.79%77.78%66.67%
   copyBoardChanges.ts83.87%77.78%66.67%
   createBoardExportRequest.ts92.86%77.78%66.67%
   createBoardSubscriptionRequest.ts87.50%80.00%64.71%
   createProjectRequest.ts92.86%77.78%66.67%
   createTeamRequest.ts92.86%77.78%66.67%
   createdBy.ts89.66%77.78%66.67%
   createdByPlatformContainers.ts89.66%77.78%66.67%
   createdByPlatformTags.ts89.66%77.78%66.67%
   customField.ts80.00%80.00%64.71%
   customFieldPlatformBulkCreateOperationExperimentalRelease.ts80.00%80.00%64.71%
   customFieldPlatformTags.ts80.00%80.00%64.71%
   dataClassificationLabel.ts74.29%77.78%66.67%
   dataClassificationLabelId.ts92.86%77.78%66.67%
   dataClassificationOrganizationSettings.ts86.67%77.78%66.67%
   dataClassificationTeamSettings.ts86.67%77.78%66.67%
   documentCreateRequest.ts83.87%77.78%66.67%
   documentData.ts89.66%77.78%66.67%
   documentDataPlatformTags.ts89.66%77.78%66.67%
   documentDataResponse.ts89.66%77.78%66.67%
   documentItem.ts97.37%88.89%66.67%
   documentUpdateRequest.ts83.87%77.78%66.67%
   documentUrlData.ts89.66%77.78%66.67%
   documentUrlDataChanges.ts89.66%77.78%66.67%
   documentUrlDataPlatformBulkCreateOperationExperimentalRelease.ts89.66%77.78%66.67%
   embedCreateRequest.ts83.87%77.78%66.67%
   embedData.ts73.68%80.00%64.71%
   embedDataResponse.ts73.68%80.00%64.71%
   embedItem.ts97.37%88.89%66.67%
   embedUpdateRequest.ts83.87%77.78%66.67%
   embedUrlData.ts87.50%80.00%64.71%
   embedUrlDataChanges.ts87.50%80.00%64.71%
   embedUrlDataPlatformBulkCreateOperationExperimentalRelease.ts87.50%80.00%64.71%
   enterpriseGetOrganizationMembers200Response.ts81.25%77.78%66.67%
   error400.ts83.87%77.78%66.67%
   error401.ts83.87%77.78%66.67%
   error403.ts83.87%77.78%66.67%
   error404.ts83.87%77.78%66.67%
   error409.ts83.87%77.78%66.67%
   error429.ts83.87%77.78%66.67%
   fixedRatioGeometry.ts86.67%77.78%66.67%
   fixedRatioNoRotationGeometry.ts89.66%77.78%66.67%
   frameChanges.ts85.29%80.00%64.71%
   frameCreateRequest.ts83.87%77.78%66.67%
   frameData.ts85.29%80.00%64.71%
   frameDataPlatformTags.ts87.88%80.00%64.71%
   frameItem.ts97.37%88.89%66.67%
   frameStyle.ts92.86%77.78%66.67%
   frameUpdateRequest.ts83.87%77.78%66.67%
   genericItem.ts97.37%88.89%66.67%
   genericItemCursorPaged.ts78.79%77.78%66.67%
   genericItemUpdate.ts89.66%77.78%66.67%
   genericSubscription.ts77.78%80.00%64.71%
   genericSubscriptionsCursorPaged.ts81.25%77.78%66.67%
   geometry.ts86.67%77.78%66.67%
   geometryNoRotation.ts89.66%77.78%66.67%
   geometryPlatformBulkCreateOperationExperimentalRelease.ts86.67%77.78%66.67%
   geometryPlatformContainers.ts86.67%77.78%66.67%
   geometryPlatformExperimentalFeatures.ts86.67%77.78%66.67%
   geometryPlatformTags.ts86.67%77.78%66.67%
   getBoards400Response.ts83.87%77.78%66.67%
   getTagsFromItem400Response.ts83.87%77.78%66.67%
   getTagsResponse.ts92.86%77.78%66.67%
   imageCreateRequest.ts83.87%77.78%66.67%
   imageData.ts89.66%77.78%66.67%
   imageDataPlatformTags.ts89.66%77.78%66.67%
   imageDataResponse.ts89.66%77.78%66.67%
   imageItem.ts97.37%88.89%66.67%
   imageUpdateRequest.ts83.87%77.78%66.67%
   imageUrlData.ts89.66%77.78%66.67%
   imageUrlDataChanges.ts89.66%77.78%66.67%
   imageUrlDataChangesPlatformBulkCreateOperationExperimentalRelease.ts89.66%77.78%66.67%
   imageUrlDataPlatformBulkCreateOperationExperimentalRelease.ts89.66%77.78%66.67%
   invitationError.ts89.66%77.78%66.67%
   invitationResult.ts89.66%77.78%66.67%
   item.ts66.67%77.78%66.67%
   itemChanges.ts76.47%77.78%66.67%
   itemConnectionChangesData.ts87.50%80.00%64.71%
   itemConnectionCreationData.ts87.50%80.00%64.71%
   itemConnectionWithLinks.ts86.67%77.78%66.67%
   itemCreate.ts78.79%77.78%66.67%
   itemData.ts61.22%80.00%64.71%
   itemDataChanges.ts82.35%80.00%64.71%
   itemDataCreate.ts71.43%80.00%64.71%
   itemPagedResponse.ts76.47%77.78%66.67%
   itemStyle.ts70.45%80.00%64.71%
   itemTypeChange.ts100.00%100.00%76.92%
Table truncated to fit comment

🤖 comment via lucassabreu/comment-coverage-clover

@kirillsud kirillsud merged commit c51f1c0 into main Sep 7, 2023
3 checks passed
@kirillsud kirillsud deleted the fix-dependabot-automerge branch September 7, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants