Skip to content

Commit

Permalink
Fix dependabot auto-merge (#245)
Browse files Browse the repository at this point in the history
`fastify/github-action-merge-dependabot` filters out PRs triggered not
by `pull_request` event. After creating a ticket to the action repo,
developers answered me that probably there is no need to use
`pull_request_target`:
fastify/github-action-merge-dependabot#474 (review).

And it seems we don't: the workflow is targeted on dependabot PRs only,
which are internal (not from forked repos), so for the `pull_request`
event the workflow will have all required write permissions.
  • Loading branch information
kirillsud authored Sep 7, 2023
1 parent 6c2438a commit c51f1c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/dependabot-auto-merge.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Dependabot
on: pull_request_target
on: pull_request

permissions:
pull-requests: write
Expand Down

0 comments on commit c51f1c0

Please sign in to comment.