Depend on gdal where it's used with rosdep #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosdep has support for gdal through three packages.
libgdal-dev
has the header files, libraries, and cmake files. IT depends on gdal-bin.gdal-bin
is the runtime libraries.python3-gdal
is the pyhon part of gdal.Since these are all used, they can be distributed by the package.xml.
The purpose of doing this is to remove the need to manually install
libgdal-dev
, which is only a useful instruction on ubuntu. For all the other platforms that can run ROS1, they need different instructions, which is hard to maintain. Rosdep is the standard and platform-independent way to manage dependencies in ROS 1 and ROS 2.To find the sources, I searched here:
https://github.com/search?q=repo%3Aros%2Frosdistro%20gdal&type=code
One thing I noticed is that
terrain_planner
references gdal in the CMakeLists, however it's not actually used there. If the package isn't used, perhaps it doesn't need to be found and linked to. This increases build time, code maintenance, and coupling. Consider removing it fromterrain_planner
?