Add ROS1 dockerfile #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
force-pushed
the
add-ros1-dockerfile
branch
from
2948aba
to
5a1d788
Compare
* Modeled after https://github.com/nachovizzo/ros_in_docker * Clarify install instructions in README Signed-off-by: Ryan Friedman <[email protected]>
* This is needed if the apt cache doesn't exist Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
add-ros1-dockerfile
branch
from
5a1d788
to
e194f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Modeled after https://github.com/nachovizzo/ros_in_docker, but just the dockerfile support. compose and devcontainers can come later as they are not essential.
I also clarify install instructions in README, as environment setup is decoupled from building.
The goal of this PR is simply to get things compiling. Supporting GUI (RVIZ) and everything can be a follow up as that's a bit tricky.
One aspect to decide is whether to bring the other repos in during the docker build with wstool (easy for users). Alternatively, we could allow/require them to already be checked out in the local environment, which would allow people to use their own modifications of the other libraries. A selectable way to manage this would be through the use of multi-stage dockerfiles.
Depending on when it's done, rosdep will still need to be run.
Tickets
Relates to #6
Depends on #10
Depends on #7
Depends on #15