EPMGCIP-179: Configure linters #31
Open
+1,032
−885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operties, update max warnings to 30
usavkov-epam
approved these changes
Dec 2, 2024
gordoney
reviewed
Dec 2, 2024
| @@ -1,5 +1,5 @@ | |||
| const config = { | |||
| '*.{js,jsx,ts,tsx}': ['eslint --fix --max-warnings 100', 'prettier --write'], | |||
| '*.{js,jsx,ts,tsx}': ['eslint --fix --max-warnings 30', 'prettier --write'], | |||
There was a problem hiding this comment.
@Dzmitry-Yaniuk
What do you think about decreasing warnings to '0'? It was '0' before switching to nextjs, so I guess we can try to continue doing that.
gordoney
reviewed
Dec 2, 2024
| @@ -71,12 +72,41 @@ | |||
| "pathGroupsExcludedImportTypes": ["react"] | |||
| } | |||
| ], | |||
| "max-depth": ["warn", 1], | |||
There was a problem hiding this comment.
What do you think about increasing it a little bit to 2 or 3?
gordoney
reviewed
Dec 2, 2024
| "next/core-web-vitals", | ||
| "eslint:recommended", | ||
| "prettier", | ||
| "plugin:@typescript-eslint/recommended" |
There was a problem hiding this comment.
Previously we also used this plugins:
'plugin:jest/recommended',
'plugin:react-hooks/recommended',
'airbnb',
'airbnb/hooks',
'airbnb-typescript'
Maybe there is a sense to add them as well. What do you think about that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.epam.com/jira/browse/EPMGCIP-179
Code changes
.gitignoreto exclude MS and JetBrains IDE working settings;.eslint.jsonfile with multiple rules ESLint rules for TypeScript, JavaScript and React;.prettierignorefile with folders to exclude some directories from checking for Prettier;messagesfolder intsconfig.json;Notes