Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPMGCIP-179: Configure linters #31

Merged
merged 14 commits into from
Dec 3, 2024
Merged

EPMGCIP-179: Configure linters #31

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a563a1b
EPMGCIP-179: Install Typescript ESLint plugins, extend existing config
Dzmitry-Yaniuk Nov 27, 2024
65db864
EPMGCIP-179: Adjust config for Prettier, add ignore files for ESLint …
Dzmitry-Yaniuk Nov 27, 2024
6bde603
EPMGCIP-179: Replace ".eslintignore" with "ignorePatterns" due to red…
Dzmitry-Yaniuk Nov 28, 2024
8829cac
EPMGCIP-179: Add some ESLint plugins for better imports management
Dzmitry-Yaniuk Nov 28, 2024
0e5b7f1
EPMGCIP-179: Apply some common rules for using React and TypeScript
Dzmitry-Yaniuk Nov 28, 2024
cad5d82
EPMGCIP-179: Include ".idea" and ".vscode" folders into .gitignore
Dzmitry-Yaniuk Nov 13, 2024
7d4e5d4
EPMGCIP-179: Resolve warnings related to incorrect order of object pr…
Dzmitry-Yaniuk Nov 29, 2024
857bc52
EPMGCIP-179: Add aliases to "messages" folder in root level, update u…
Dzmitry-Yaniuk Nov 29, 2024
1fbcba9
EPMGCIP-179: Added Visual Studio settings as ignored files in ".gitig…
Dzmitry-Yaniuk Nov 29, 2024
99eef80
EPMGCIP-179: Adjust basic ruleset for ".eslintrc.json", add small enh…
Dzmitry-Yaniuk Nov 29, 2024
4aed9dd
EPMGCIP-179: Extend max nesting to 2 level in ".eslintrc.json"
Dzmitry-Yaniuk Dec 2, 2024
ac08edb
EPMGCIP-179: Add useful ESLint plugins for Jest and React hooks, upda…
Dzmitry-Yaniuk Dec 2, 2024
552bd71
EPMGCIP-179: Add AQA classname for "ImageGallery" root component, upd…
Dzmitry-Yaniuk Dec 2, 2024
690ccef
EPMGCIP-179: Decrease allowed amount of ESLint warnings from 30 to 20
Dzmitry-Yaniuk Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@
"no-throw-literal": "off",
"no-warning-comments": "warn",
"react/display-name": "warn",
"react/function-component-definition": [
"warn",
{
"namedComponents": "arrow-function"
}
],
"react/sort-comp": "warn",
"sort-keys": "warn",
"unused-imports/no-unused-imports": "error"
Expand Down
2 changes: 1 addition & 1 deletion lint-staged.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const config = {
'*.{js,jsx,ts,tsx}': ['eslint --fix --max-warnings 100', 'prettier --write'],
'*.{js,jsx,ts,tsx}': ['eslint --fix --max-warnings 30', 'prettier --write'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dzmitry-Yaniuk
What do you think about decreasing warnings to '0'? It was '0' before switching to nextjs, so I guess we can try to continue doing that.

Copy link
Collaborator Author

@Dzmitry-Yaniuk Dzmitry-Yaniuk Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! From my opinion absence of warnings in code is a project good shape indicator.
However, with existing applied rules we get already around 10 warnings, refactoring code in terms of this PR might not be a good idea. Perhaps I can set this limit now to 20 items?

Otherwise code cannot be pushed without bypass option for git commit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, so let's set the lowest available number for now and I will create additional ticket for reaching 0

'*.{json,scss,css}': ['prettier --write'],
};

Expand Down
6 changes: 3 additions & 3 deletions src/components/atoms/Dropdown/Dropdown.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import Dropdown from './Dropdown';

describe('Dropdown', () => {
const options = [
{ id: '1', text: 'Option 1', image: '/image1.png' },
{ id: '2', text: 'Option 2', image: '/image2.png' },
{ id: '3', text: 'Option 3', image: '/image3.png' },
{ id: '1', image: '/image1.png', text: 'Option 1' },
{ id: '2', image: '/image2.png', text: 'Option 2' },
{ id: '3', image: '/image3.png', text: 'Option 3' },
];

it('displays the default option', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/molecules/LanguageSwitcher/LanguageSwitcher.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ Storage.prototype.setItem = jest.fn();
const replaceMock = jest.fn();

jest.mock('@/navigation', () => ({
usePathname: jest.fn().mockReturnValue('/test'),
useRouter: jest.fn().mockReturnValue({
replace: (a: string, b: string) => replaceMock(a, b),
}),
usePathname: jest.fn().mockReturnValue('/test'),
}));

describe('LanguageSwitcher', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/molecules/LanguageSwitcher/LanguageSwitcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ export default function LanguageSwitcher() {

const options = locales.map((lang) => ({
id: lang,
text: lang,
image: `/images/${lang}.png`,
text: lang,
}));

return (
Expand Down
2 changes: 1 addition & 1 deletion src/components/pages/Exhibit/Exhibit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export default function ExhibitPage({ exhibit, slug }: Props) {

const images =
exhibit?.imagesCollection?.items?.map((i) => ({
url: i?.url || '',
id: i?.sys.id || '',
url: i?.url || '',
})) || [];

const title = exhibit?.[`name${currentLocale}`];
Expand Down