Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPMGCIP-179: Configure linters #31

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+1,061 −880
Open

EPMGCIP-179: Configure linters #31

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a563a1b
EPMGCIP-179: Install Typescript ESLint plugins, extend existing config
Dzmitry-Yaniuk Nov 27, 2024
65db864
EPMGCIP-179: Adjust config for Prettier, add ignore files for ESLint …
Dzmitry-Yaniuk Nov 27, 2024
6bde603
EPMGCIP-179: Replace ".eslintignore" with "ignorePatterns" due to red…
Dzmitry-Yaniuk Nov 28, 2024
8829cac
EPMGCIP-179: Add some ESLint plugins for better imports management
Dzmitry-Yaniuk Nov 28, 2024
0e5b7f1
EPMGCIP-179: Apply some common rules for using React and TypeScript
Dzmitry-Yaniuk Nov 28, 2024
cad5d82
EPMGCIP-179: Include ".idea" and ".vscode" folders into .gitignore
Dzmitry-Yaniuk Nov 13, 2024
7d4e5d4
EPMGCIP-179: Resolve warnings related to incorrect order of object pr…
Dzmitry-Yaniuk Nov 29, 2024
857bc52
EPMGCIP-179: Add aliases to "messages" folder in root level, update u…
Dzmitry-Yaniuk Nov 29, 2024
1fbcba9
EPMGCIP-179: Added Visual Studio settings as ignored files in ".gitig…
Dzmitry-Yaniuk Nov 29, 2024
99eef80
EPMGCIP-179: Adjust basic ruleset for ".eslintrc.json", add small enh…
Dzmitry-Yaniuk Nov 29, 2024
4aed9dd
EPMGCIP-179: Extend max nesting to 2 level in ".eslintrc.json"
Dzmitry-Yaniuk Dec 2, 2024
ac08edb
EPMGCIP-179: Add useful ESLint plugins for Jest and React hooks, upda…
Dzmitry-Yaniuk Dec 2, 2024
552bd71
EPMGCIP-179: Add AQA classname for "ImageGallery" root component, upd…
Dzmitry-Yaniuk Dec 2, 2024
690ccef
EPMGCIP-179: Decrease allowed amount of ESLint warnings from 30 to 20
Dzmitry-Yaniuk Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"extends": ["next/core-web-vitals", "prettier"],
"root": true,
"extends": [
"next/core-web-vitals",
"eslint:recommended",
"prettier",
"plugin:@typescript-eslint/recommended"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we also used this plugins:

'plugin:jest/recommended',
'plugin:react-hooks/recommended',
'airbnb',
'airbnb/hooks',
'airbnb-typescript'

Maybe there is a sense to add them as well. What do you think about that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are existing eslint:recommended and prettier plugins I assume airbnb related plugins might be a little redundant (quite rules in common). What do you think?

],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": "latest",
"project": "./tsconfig.json",
"ecmaFeatures": {
"jsx": true
}
},
"plugins": ["@typescript-eslint"],
"rules": {
"@next/next/no-img-element": 0
"@next/next/no-img-element": "off"
}
}
Loading