Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActivityLifecycleListener extend ActivityLifecycleCallacks with no-op defaults #1124

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jul 18, 2024

Goal

Make the listener implement ActivityLifecycleCallbacks with default no-op implementations so we can observe more lifecycle events.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (0a3fa76) to head (de57070).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
- Coverage   82.90%   82.89%   -0.02%     
==========================================
  Files         433      433              
  Lines       11278    11282       +4     
  Branches     1755     1755              
==========================================
+ Hits         9350     9352       +2     
- Misses       1147     1149       +2     
  Partials      781      781              
Files Coverage Δ
...nal/session/lifecycle/ActivityLifecycleListener.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@bidetofevil bidetofevil force-pushed the hho/activity-listener-refactor branch from 74a2e3d to cc3007f Compare July 25, 2024 18:35
@bidetofevil bidetofevil marked this pull request as ready for review July 25, 2024 19:11
@bidetofevil bidetofevil requested a review from a team as a code owner July 25, 2024 19:11
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming that ActivityLifecycleCallbacks is available in all the versions we support

Base automatically changed from hho/rename-activity-listener to master July 26, 2024 19:50
@bidetofevil bidetofevil force-pushed the hho/activity-listener-refactor branch from cc3007f to de57070 Compare July 26, 2024 19:50
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants