-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ActivityLifecycleListener extend ActivityLifecycleCallacks with no-op defaults #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 82.90% 82.89% -0.02%
==========================================
Files 433 433
Lines 11278 11282 +4
Branches 1755 1755
==========================================
+ Hits 9350 9352 +2
- Misses 1147 1149 +2
Partials 781 781
|
bidetofevil
force-pushed
the
hho/rename-activity-listener
branch
from
July 25, 2024 18:35
e077e6c
to
fa010ed
Compare
bidetofevil
force-pushed
the
hho/activity-listener-refactor
branch
from
July 25, 2024 18:35
74a2e3d
to
cc3007f
Compare
fractalwrench
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - assuming that ActivityLifecycleCallbacks
is available in all the versions we support
bidetofevil
force-pushed
the
hho/activity-listener-refactor
branch
from
July 26, 2024 19:50
cc3007f
to
de57070
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Make the listener implement
ActivityLifecycleCallbacks
with default no-op implementations so we can observe more lifecycle events.