Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActivityLifecycleListener extend ActivityLifecycleCallacks with no-op defaults #1124

Merged
merged 2 commits into from
Jul 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,32 +1,25 @@
package io.embrace.android.embracesdk.internal.session.lifecycle

import android.app.Activity
import android.app.Application.ActivityLifecycleCallbacks
import android.os.Bundle

/**
* Listener implemented by observers of the [ActivityLifecycleTracker].
* Implementation of [ActivityLifecycleCallbacks] with no-op defaults
*/
public interface ActivityLifecycleListener {

/**
* Triggered when an activity is opened.
*
* @param activity details of the activity
*/
public fun onActivityStarted(activity: Activity) {}

/**
* Triggered when an activity is closed.
*
* @param activity details of the activity
*/
public fun onActivityStopped(activity: Activity) {}

/**
* Triggered when an activity is created.
*
* @param activity the activity
* @param bundle the bundle
*/
public fun onActivityCreated(activity: Activity, bundle: Bundle?) {}
public interface ActivityLifecycleListener : ActivityLifecycleCallbacks {

public override fun onActivityCreated(activity: Activity, bundle: Bundle?) {}

Check warning on line 12 in embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt#L12

Added line #L12 was not covered by tests

public override fun onActivityStarted(activity: Activity) {}

Check warning on line 14 in embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt#L14

Added line #L14 was not covered by tests

public override fun onActivityResumed(activity: Activity) {}

Check warning on line 16 in embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt#L16

Added line #L16 was not covered by tests

public override fun onActivityPaused(activity: Activity) {}

Check warning on line 18 in embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt#L18

Added line #L18 was not covered by tests

public override fun onActivityStopped(activity: Activity) {}

Check warning on line 20 in embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt#L20

Added line #L20 was not covered by tests

public override fun onActivitySaveInstanceState(activity: Activity, outState: Bundle) {}

Check warning on line 22 in embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt#L22

Added line #L22 was not covered by tests

public override fun onActivityDestroyed(activity: Activity) {}

Check warning on line 24 in embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt#L24

Added line #L24 was not covered by tests
}