Rename methods in ActivityLifecycleListenerInterface to match lifecyc…

…le methods
embrace-io · Jul 17, 2024 · e077e6c · e077e6c
1 parent 9f5b3b8
commit e077e6c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...in/java/io/embrace/android/embracesdk/internal/capture/crumbs/EmbraceBreadcrumbService.kt b/...in/java/io/embrace/android/embracesdk/internal/capture/crumbs/EmbraceBreadcrumbService.kt
@@ -96,7 +96,7 @@ internal class EmbraceBreadcrumbService(
         }
     }
 
-    override fun onView(activity: Activity) {
+    override fun onActivityStarted(activity: Activity) {
         if (configService.breadcrumbBehavior.isAutomaticActivityCaptureEnabled()) {
             logView(activity.javaClass.name, clock.now())
         }
@@ -105,7 +105,7 @@ internal class EmbraceBreadcrumbService(
     /**
      * Close all open fragments when the activity closes
      */
-    override fun onViewClose(activity: Activity) {
+    override fun onActivityStopped(activity: Activity) {
         if (configService.breadcrumbBehavior.isAutomaticActivityCaptureEnabled()) {
             dataSourceModuleProvider()?.viewDataSource?.dataSource?.onViewClose()
         }

diff --git a/...ava/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt b/...ava/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleListener.kt
@@ -13,14 +13,14 @@ internal interface ActivityLifecycleListener {
      *
      * @param activity details of the activity
      */
-    fun onView(activity: Activity) {}
+    fun onActivityStarted(activity: Activity) {}
 
     /**
      * Triggered when an activity is closed.
      *
      * @param activity details of the activity
      */
-    fun onViewClose(activity: Activity) {}
+    fun onActivityStopped(activity: Activity) {}
 
     /**
      * Triggered when an activity is created.

diff --git a/...java/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleTracker.kt b/...java/io/embrace/android/embracesdk/internal/session/lifecycle/ActivityLifecycleTracker.kt
@@ -77,7 +77,7 @@ internal class ActivityLifecycleTracker(
         updateStateWithActivity(activity)
         stream(listeners) { listener: ActivityLifecycleListener ->
             try {
-                listener.onView(activity)
+                listener.onActivityStarted(activity)
             } catch (ex: Exception) {
                 logger.logWarning(ERROR_FAILED_TO_NOTIFY)
                 logger.trackInternalError(InternalErrorType.ACTIVITY_LISTENER_FAIL, ex)
@@ -104,7 +104,7 @@ internal class ActivityLifecycleTracker(
     override fun onActivityStopped(activity: Activity) {
         stream(listeners) { listener: ActivityLifecycleListener ->
             try {
-                listener.onViewClose(activity)
+                listener.onActivityStopped(activity)
             } catch (ex: Exception) {
                 logger.logWarning(ERROR_FAILED_TO_NOTIFY)
                 logger.trackInternalError(InternalErrorType.ACTIVITY_LISTENER_FAIL, ex)

diff --git a/...d-sdk/src/test/java/io/embrace/android/embracesdk/session/ActivityLifecycleTrackerTest.kt b/...d-sdk/src/test/java/io/embrace/android/embracesdk/session/ActivityLifecycleTrackerTest.kt
@@ -120,7 +120,7 @@ internal class ActivityLifecycleTrackerTest {
 
         activityLifecycleTracker.onActivityStarted(mockActivity)
 
-        verify { mockActivityLifecycleListener.onView(mockActivity) }
+        verify { mockActivityLifecycleListener.onActivityStarted(mockActivity) }
         assertEquals(mockActivity, activityLifecycleTracker.foregroundActivity)
     }
 
@@ -152,7 +152,7 @@ internal class ActivityLifecycleTrackerTest {
 
         activityLifecycleTracker.onActivityStopped(mockActivity)
 
-        verify { mockActivityLifecycleListener.onViewClose(mockActivity) }
+        verify { mockActivityLifecycleListener.onActivityStopped(mockActivity) }
     }
 
     @Test