Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to link to new URL API docs structure #15723

Closed
19 tasks done
locks opened this issue Oct 10, 2017 · 27 comments
Closed
19 tasks done

Update documentation to link to new URL API docs structure #15723

locks opened this issue Oct 10, 2017 · 27 comments

Comments

@locks
Copy link
Contributor

locks commented Oct 10, 2017

So for each package in ember source, we'd like to convert api doc links to our new url structure (example: https://emberjs.com/api/ember/release/classes/Application)

Additionally we'd like to convert references to old Ember namespaced classes to their simplified post RFC 176 names.
(example: documentation might refer to Ember.Object, while we'd want it to be EmberObject now)
See the readme for https://github.com/ember-cli/ember-rfc176-data for the mappings.

here's a list of all subdirectories in the packages/ directory. There may or may not be things to convert in some of these. if you verify these are not in need of conversion we can check them too.

Indicate in comments when you want to work on a directory and its yours. We will add your name to the item. Also when you submit a PR, mention this issue "#15723" so that the link shows up here.

Thanks and Happy coding!

Update: Be sure to prepend your commits to [doc beta], so we can get these changes into 3.0!
See https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md#documentation

@scissorsneedfoodtoo
Copy link

Hi there. I'd like to help out with this task, but I'm quite new to ember.js and contribution. Could you point me toward the documentation that needs to be updated and the new URL structure?

@tinoromero
Copy link

Hi! Is this issue taken? I can help!

@toddjordan
Copy link
Contributor

@scissorsneedfoodtoo @juventinoromero Thanks for your willingness to help! What needs to happen is any link referring to a legacy API url, (such as emberjs.com/api/ember/Ember.Application.html) needs to be replaced with its new equivalent (https://emberjs.com/api/ember/release/classes/Application).

Unfortunately, referring to links with release vs a specific version 2.17 has regressed, and we need to address this before proceeding with this fix.

See: ember-learn/ember-api-docs#407

Once fixed, we can split up the work by source folder. Will create a quest-issue style checklist for this and you can grab sections of the source by folder.

@tinoromero
Copy link

Ok. Thanks! I'll check that issue.

@scissorsneedfoodtoo
Copy link

scissorsneedfoodtoo commented Dec 26, 2017

@toddjordan, sorry for the late response, and thank you for such a detailed message.

@juventinoromero, go for it! I've gotten wrapped up in some other projects. Good luck with everything!

@tinoromero
Copy link

@scissorsneedfoodtoo thanks! I'll be working on it once I get some time off another project. Feel free to work on it too :)

@LukeBousfield
Copy link

@scissorsneedfoodtoo can I work on this?

@toddjordan
Copy link
Contributor

@scissorsneedfoodtoo @juventinoromero @CodingPower472 The update to apidocs that supports the "release" url is just in and deployed today, so we can go ahead and convert links from the inline documentation. I'd suggest breaking up by directory so folks can work concurrently as they get band with. I'll update the description to make it more "quest" style.

But yes, feel free to start @CodingPower472

@LukeBousfield
Copy link

@toddjordan Is this an issue with ember-learn/ember-api-docs or emberjs/ember.js? (Sorry for the stupid question)

@Serabe
Copy link
Member

Serabe commented Jan 6, 2018

Please, before starting with any part, ask here to lock it so we don't duplicate efforts.

Thank you!

@Serabe Serabe added the Quest label Jan 6, 2018
@toddjordan
Copy link
Contributor

@CodingPower472 its here in ember.js because all the code changes need to be made in this repo, to the inline documentation.

@ynotdraw
Copy link

ynotdraw commented Jan 8, 2018

I can lend a hand. I'll start with the bottom three:

  • ember-testing
  • ember-extension-support
  • ember-utils

@scissorsneedfoodtoo
Copy link

@CodingPower472, @ynotdraw, go for it! I'm a bit wrapped up in another project now.

@tinoromero
Copy link

@CodingPower472 @ynotdraw go ahead! I'm also busy with another project but a week or so. I'll catch up with you later. Thanks!

@williamhaley
Copy link
Contributor

Can I take on ember-debug?

@toddjordan
Copy link
Contributor

sure can @williamhaley let me know if you have questions!

@toddjordan
Copy link
Contributor

check out @ynotdraw 's pr for an example of what needs to be done #16108

@jenweber
Copy link
Contributor

Similar work being tracked in emberjs/guides#2177 for the Guides

@ynotdraw
Copy link

I should have some bandwidth this week/weekend for another set. Feel free to assign these to me:

  • ember-template-compiler
  • node-module
  • ember-environment
  • loader

@ynotdraw
Copy link

Looks like the following do not require any RFC176 or url updates and can be marked off the list:

  • ember-template-compiler
  • node-module
  • ember-environment
  • loader

I'll move on to the next three that appear to need changes:

  • ember-routing
  • internal-test-helpers
  • ember-console

@karthiicksiva
Copy link
Contributor

I will take ember-metal package.

@MarcoUmpierrez
Copy link
Contributor

MarcoUmpierrez commented Jan 22, 2018

ember package looks like it doesn't require any change either. There's only one file in that package (index.js) and no links pointing to the API docs.

Edit: There were some references to the global API. I made a PR for it 😄

@Parrryy
Copy link
Contributor

Parrryy commented Jan 22, 2018

I can do the ember-application, it'll be my first contribution. Seems like a good one to start.

@Parrryy
Copy link
Contributor

Parrryy commented Jan 23, 2018

I'll pick up container, ember-views and external-helpers today.

@Parrryy
Copy link
Contributor

Parrryy commented Jan 23, 2018

container and external-helpers have no changes that I can see. So will pick up ember-glimmer.

@toddjordan
Copy link
Contributor

Thanks to everyone who's submitted prs/looked at packages ❤️ I'll be doing some reviews this evening.

@toddjordan
Copy link
Contributor

Looks like we can close the book on this one. Thanks so much @ynotdraw @Parrryy @Karthiick @MarcoUmpierrez @williamhaley for making it happen. It was cool to see it come together ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests