Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc beta] Update docs for rfc176 #16165

Closed
wants to merge 2 commits into from

Conversation

Parrryy
Copy link
Contributor

@Parrryy Parrryy commented Jan 22, 2018

PR for #15723 for ember-application. I couldn't seem to find a replacement for Ember.View, assuming that just needs to go away but probably in a different pr.

Couldn't see any link related changes.

@@ -138,14 +146,16 @@ let librariesRegistered = false;
append views inside it!

To learn more about the events Ember components use, see
[components/handling-events](https://guides.emberjs.com/v2.6.0/components/handling-events/#toc_event-names).
[components/handling-events](https://guides.emberjs.com/v2.18.0/components/handling-events/#toc_event-names).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this as I was updating this file anyway. Let me know if it's an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be https://guides.emberjs.com/current/components/handling-events/#toc_event-names

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added change.

@ynotdraw
Copy link

Correct - from what I've been told so far, Ember.View will go away in another PR, so it's fine to leave these spots as-is.

@toddjordan
Copy link
Contributor

@Parrryy looks great! Do you mind squashing your commits and prepending the commit message with [doc beta] so we know to put this into 3.0?

Let me know if you are new to git rebase --interactive and need help.

@Parrryy Parrryy force-pushed the fix/rfc176-api-doc-changes branch 3 times, most recently from 5d5d924 to 1255a54 Compare January 29, 2018 16:33
[BUGFIX beta] Remove humanize() call from generated test descriptions

[DOC beta] rfc176 api doc update
@Parrryy Parrryy closed this Jan 29, 2018
@Parrryy Parrryy deleted the fix/rfc176-api-doc-changes branch January 29, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants