[doc beta] Update docs for rfc176 #16165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parrryy
commented
Jan 22, 2018
| @@ -138,14 +146,16 @@ let librariesRegistered = false; | |||
| append views inside it! | |||
|
|
|||
| To learn more about the events Ember components use, see | |||
| [components/handling-events](https://guides.emberjs.com/v2.6.0/components/handling-events/#toc_event-names). | |||
| [components/handling-events](https://guides.emberjs.com/v2.18.0/components/handling-events/#toc_event-names). | |||
There was a problem hiding this comment.
Updated this as I was updating this file anyway. Let me know if it's an issue.
There was a problem hiding this comment.
should be https://guides.emberjs.com/current/components/handling-events/#toc_event-names
|
Correct - from what I've been told so far, |
|
@Parrryy looks great! Do you mind squashing your commits and prepending the commit message with [doc beta] so we know to put this into 3.0? Let me know if you are new to git rebase --interactive and need help. |
Parrryy
force-pushed
the
fix/rfc176-api-doc-changes
branch
3 times, most recently
from
5d5d924
to
1255a54
Compare
[BUGFIX beta] Remove humanize() call from generated test descriptions [DOC beta] rfc176 api doc update
Parrryy
force-pushed
the
fix/rfc176-api-doc-changes
branch
from
ec19780
to
504d85b
Compare
Parrryy
force-pushed
the
fix/rfc176-api-doc-changes
branch
from
504d85b
to
1e2c618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #15723 for ember-application. I couldn't seem to find a replacement for
Ember.View, assuming that just needs to go away but probably in a different pr.Couldn't see any link related changes.