[doc beta] fixing references to Ember in the subdirectory ember

[MarcoUmpierrez]

In relation to this issue #15723, I have fixed the references to Ember in the subdirectory ember.

There were some things I wasn't sure about; I list them here so anyone with more experience can guide me to replace them correctly:

1. lib/index.js: here appears Ember.String.loc() in a comment, but I wasn't sure if I should replace it with just "loc() helper" or "loc() helper in @ember/string".

2. tests/error_handler_test.js:

• Ember.onerror has no replacement as far as I know. I researched it and found this comment of rwjblue. The same happens with Ember.testing.
• I wasn't sure what to do with Ember.Test. Should I import Test from 'test'?

I think the rest should be ok, but I would appreciate if someone can check it to make sure that I didn't anything wrong 😄

[locks]

CI is complaining about ember/tests/error_handler_test.js: "TestAdapter" is read-only

[locks]

Can you change this to import { inject as service } from '@ember/service';

[MarcoUmpierrez]

@locks Done 😄

[locks]

This doesn't seem quite right, as CI is failing throughout all jobs.

[MarcoUmpierrez]

@locks This one I wasn't completely sure because of this Ember.Test.adapter = ADAPTER. Maybe that's the reason why CI complains. Should I revert it? or is it safe to remove the const ADAPTER and the check if (Ember.Test)?

[toddjordan]

Really updating live source code is not really the scope of #15723 and I'd be fine just updating inline docs here (and possibly assert/error messages).

[toddjordan]

I believe imported variables are treated as const and you can't assign to them like this.

[toddjordan]

line 390 refers to Ember.String.loc. Those types of refernces are what we are looking to update to String.loc

[toddjordan]

As per your question, only mappings detailed here https://github.com/ember-cli/ember-rfc176-data/blob/master/mappings.json
should be converted

[MarcoUmpierrez]

Thanks for your review @toddjordan! I've made the corrections according to your comments. I couldn't replace Ember.inject.servicethough because in Travis I got the following error for Edge, Safari and IE:

        Log: |
            { type: 'error',
              text: 'Could not find module @ember/service required by: 
              ember/tests/routing/query_params_test/shared_state_test at 
              http://127.0.0.1:7774/8786/dist/ember.debug.js, line 21\n' }

Here is the link to the failed build in Travis.

[toddjordan]

@MarcoUmpierrez Great! I think this is good as is. Like I mentioned I'm fine not changing any prod imports with this pr and sticking with the inline docs (and some messages).

The last thing I'd ask if is if you could use git to squash the commits into one and prepend the commit comment with [doc beta], so we know to make sure your updates get into 3.0 ❤️

Let me know if you need help with this.

[MarcoUmpierrez]

@toddjordan done!

CI has been addressed

[toddjordan]

Thanks @MarcoUmpierrez !!