Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to link to new URL API docs structure #16126

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

ynotdraw
Copy link

Takes care of #15723 ember-runtime, ember-testing, ember-extension-support, and ember-utils

student.toString() //=> "<(subclass of Person):ember1025>"
const Student = Person.extend();
let student = Student.create();
student.toString(); //=> "<(subclass of Person):ember1025>"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added semicolons here for consistency and on line 534.

@@ -609,7 +623,10 @@ let ClassMixinProps = {
You can also pass `Mixin` classes to add additional properties to the subclass.

```javascript
const Person = Ember.Object.extend({
import EmberObject from '@ember/object';
import Mixin from '@ember/object/mixin';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added for the rest of the example (mixin created on line 635)

@@ -60,10 +60,12 @@ export default Mixin.create({
and target will be retrieved from properties of the object. For example:

```javascript
import { alias } from '@ember/object/computed';

App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left Ember.View.extend here alone, since there isn't a documented import with RFC176. I assumed these types of examples could be filed as an issue and updated at a later date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, Ember.View probably needs to go away, but that's for another pr...

@toddjordan toddjordan merged commit 0240cac into emberjs:master Jan 15, 2018
@toddjordan
Copy link
Contributor

Awesome job. Thanks @ynotdraw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants