Update documentation to link to new URL API docs structure #16126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynotdraw
commented
Jan 14, 2018
| student.toString() //=> "<(subclass of Person):ember1025>" | ||
| const Student = Person.extend(); | ||
| let student = Student.create(); | ||
| student.toString(); //=> "<(subclass of Person):ember1025>" |
There was a problem hiding this comment.
Added semicolons here for consistency and on line 534.
| @@ -609,7 +623,10 @@ let ClassMixinProps = { | |||
| You can also pass `Mixin` classes to add additional properties to the subclass. | |||
|
|
|||
| ```javascript | |||
| const Person = Ember.Object.extend({ | |||
| import EmberObject from '@ember/object'; | |||
| import Mixin from '@ember/object/mixin'; | |||
There was a problem hiding this comment.
Added for the rest of the example (mixin created on line 635)
| @@ -60,10 +60,12 @@ export default Mixin.create({ | |||
| and target will be retrieved from properties of the object. For example: | |||
|
|
|||
| ```javascript | |||
| import { alias } from '@ember/object/computed'; | |||
|
|
|||
| App.SaveButtonView = Ember.View.extend(Ember.TargetActionSupport, { | |||
There was a problem hiding this comment.
I left Ember.View.extend here alone, since there isn't a documented import with RFC176. I assumed these types of examples could be filed as an issue and updated at a later date?
There was a problem hiding this comment.
yeah, Ember.View probably needs to go away, but that's for another pr...
toddjordan
approved these changes
Jan 15, 2018
|
Awesome job. Thanks @ynotdraw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of #15723 ember-runtime, ember-testing, ember-extension-support, and ember-utils