Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update RELEASE.md #12983

Merged
merged 10 commits into from
May 30, 2024
Merged

docs: update RELEASE.md #12983

merged 10 commits into from
May 30, 2024

Conversation

endorama
Copy link
Member

@endorama endorama commented Apr 17, 2024

This PR aims at refreshing the release documentation for apm-server. I'll use it to collect changes as I go through the release process as release manager.

Closes #12864

release notes are no more present in docs/release_notes.asciidoc
Copy link
Contributor

mergify bot commented Apr 17, 2024

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 17, 2024
@@ -17,9 +17,9 @@ For patch releases, only the version on the existing major and minor version bra
* Review existing [changelogs/head](https://github.com/elastic/apm-server/tree/main/changelogs/head.asciidoc) to ensure all relevant notes have been added.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: how do I make sure there are no PR to be merged? I checked all PRs that don't have a backport-skip label applied through this search. If that is appropriate I would add it to the documentation to help streamline this step.

dev_docs/RELEASES.md Outdated Show resolved Hide resolved
@carsonip carsonip self-requested a review April 17, 2024 08:51
Guide the release manager to leverage available automations instead of performing manual actions.
@endorama endorama marked this pull request as ready for review May 2, 2024 10:37
@endorama endorama requested a review from a team as a code owner May 2, 2024 10:37
kruskall
kruskall previously approved these changes May 8, 2024
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is missing docs release process. It used to be done by docs team but it is now our responsibility to do so. Can you figure out at which stage that should happen and update the docs, and give an example?

dev_docs/RELEASES.md Outdated Show resolved Hide resolved
dev_docs/RELEASES.md Outdated Show resolved Hide resolved
to create an overview over the PRs that need testing. For example, [test plan link for 8.3.0](https://github.com/elastic/apm-server/issues?q=label%3Atest-plan+is%3Aclosed+label%3Av8.3.0).
* Add other test cases that require manual testing, such as test scenarios on ESS, that are not covered by automated tests or
OS compatibility smoke tests for supporting new operating systems.
Create a github issue for testing the release branch ([use the GitHub issue `test plan` template](https://github.com/elastic/apm-server/issues/new?assignees=&labels=test-plan&projects=&template=test-plan.md)), It should contain:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about including a recent example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the link on line 41 or 43? This link brings you to the new issue view with the test-plan template selected (there is a separate PR for updating the test plan). On line 43 instead there is a link to a 8.3.0 test plan, which looks like what you would like to see updated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like an new link to a recent test plan issue, in addition to the existing link to the issue view with filtered with test-plan label

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was suggesting to add a link to an example like #12822. I find it easier to see an actual example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 43a62fe (#12983)

@endorama
Copy link
Member Author

endorama commented May 8, 2024

@carsonip thanks for pointing to the doc release. I'll dig into that.

dev_docs/RELEASES.md Show resolved Hide resolved

The release manager will ping the teams, but you can already prepare this in advance on the day after Feature Freeze.
* Trigger release workflow manually
* For **patch releases**: run the [`run-patch-release`](https://github.com/elastic/apm-server/actions/workflows/run-patch-release.yml) workflow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describe what patch release automation does. It does not include changelog changes. It updates some versions iirc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For patch release notes we could add something like this:

  • For patch releases, release notes must be manually added:
    • Add a new section to the existing release notes file (Sample PR).
    • Review the changelogs/head file and move all relevant release notes from head.asciidoc to release_version.asciidoc. If changes do not apply to the version being released, keep them in the head.asciidoc file.
    • Review the commits in the release to ensure all changes are reflected in the release notes.
    • Add your PR to the documentation release issue (Sample Issue).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the suggested changes to 837bc9a (#12983)

kruskall
kruskall previously approved these changes May 27, 2024
kruskall
kruskall previously approved these changes May 27, 2024
@endorama
Copy link
Member Author

Thank you @kruskall for the super fast re-review! I'll wait @carsonip opinion before merging as we started this PR as a sort of brain dump from him and I'd like a final ✔️ from him.

dev_docs/RELEASES.md Outdated Show resolved Hide resolved
dev_docs/RELEASES.md Outdated Show resolved Hide resolved
@endorama endorama enabled auto-merge (squash) May 30, 2024 12:50
@endorama endorama merged commit 8e2854b into main May 30, 2024
7 checks passed
@endorama endorama deleted the endorama-patch-1 branch May 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document release process with the automation workflow
4 participants