Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Carson Ip <[email protected]>
  • Loading branch information
endorama and carsonip authored May 28, 2024
1 parent 837bc9a commit 963ac7c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dev_docs/RELEASES.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ For patch releases, only the version on the existing major and minor version bra

* Trigger release workflow manually
* For **patch releases**: run the [`run-patch-release`](https://github.com/elastic/apm-server/actions/workflows/run-patch-release.yml) workflow.
This workflow will: create the release branch; update version across codebase; commit and create PR targetting release branch.
This workflow will: create the release branch; update version across codebase; commit and create PR targeting the release branch.
Release notes for patch releases must be manually added:
* Add a new section to the existing release notes file ([Sample PR](https://github.com/elastic/apm-server/pull/12680)).
* Review the [changelogs/head](https://github.com/elastic/apm-server/tree/main/changelogs/head.asciidoc) file and move all relevant release notes from `head.asciidoc` to `release_version.asciidoc`. If changes do not apply to the version being released, keep them in the `head.asciidoc` file.
* Review the [changelogs/head](https://github.com/elastic/apm-server/tree/main/changelogs/head.asciidoc) file and move relevant changelog entries from `head.asciidoc` to `release_version.asciidoc` if the change is backported to release_version. If changes do not apply to the version being released, keep them in the `head.asciidoc` file.
* Review the commits in the release to ensure all changes are reflected in the release notes.
* Add your PR to the documentation release issue ([Sample Issue](https://github.com/elastic/dev/issues/2485)).
* For **minor releases**: run the [`run-minor-release`](https://github.com/elastic/apm-server/actions/workflows/run-minor-release.yml) workflow.
Expand Down

0 comments on commit 963ac7c

Please sign in to comment.