Skip to content

Commit e1aa910

Browse files
endoramacarsonip
andauthored
Apply suggestions from code review
Co-authored-by: Carson Ip <[email protected]>
1 parent 49ae368 commit e1aa910

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

dev_docs/RELEASES.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ For patch releases, only the version on the existing major and minor version bra
1515

1616
## Day after Feature Freeze
1717

18-
* Update Changelog
19-
* This step is automated
18+
* Trigger release workflow manually
2019
* For **patch releases**: run the [`run-patch-release`](https://github.com/elastic/apm-server/actions/workflows/run-patch-release.yml) workflow.
2120
* For **minor releases**: run the [`run-minor-release`](https://github.com/elastic/apm-server/actions/workflows/run-minor-release.yml) workflow.
2221
This workflow will: create the release branch; update the changelog for the release branch and open a PR targeting the release branch titled `<major>.<minor>: update docs`; create a PR on `main` titled `<major>.<minor>: update docs, mergify, versions and changelogs`. Before merging them compare commits between latest minor and the new minor versions and ensure all relevant PRs have been included in the Changelog. If not, amend it in both PRs. Request and wait a PR review from the team before merging.
@@ -42,7 +41,7 @@ For patch releases, only the version on the existing major and minor version bra
4241
Create a github issue for testing the release branch ([use the GitHub issue `test plan` template](https://github.com/elastic/apm-server/issues/new?assignees=&labels=test-plan&projects=&template=test-plan.md)), It should contain:
4342
* A link to all PRs in the APM Server repository that need to be tested manually. Use the `test-plan` label and the version label (create it if it does not exist).
4443
to create an overview over the PRs that need testing. For example, [test plan link for 8.3.0](https://github.com/elastic/apm-server/issues?q=label%3Atest-plan+is%3Aclosed+label%3Av8.3.0).
45-
What we aim for is testing all functional changes applied to the new version. Review any PR updating `elastic/go-docappener` and `elastic/apm-data` dependencies, as some functional changes happens through these dependencies.
44+
What we aim for is testing all functional changes applied to the new version. Review any PR updating `elastic/go-docappender` and `elastic/apm-data` dependencies, as some functional changes happens through these dependencies.
4645
Any non-functional change or any change that is already covered by automated tests must not be included.
4746
* Add other test cases that require manual testing, such as test scenarios on ESS, that are not covered by automated tests or OS compatibility smoke tests for supporting new operating systems.
4847

0 commit comments

Comments
 (0)