-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: add simple part of vue/vue3-recommended rules #5170
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
That we have tests when we turn the following rules on: "vue/no-deprecated-dollar-scopedslots-api": "off", "vue/no-deprecated-slot-attribute": "off", "vue/no-deprecated-slot-scope-attribute": "off", Issue: ecamp#5121 Related to: ecamp#5170, ecamp#5122
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if it has to do with this PR, but I can't create new activities on the Picasso (by dragging).
Seems that the lint rule rewrites the event identifier where you register the event, but not the place where you emit the event. |
@@ -7,8 +7,8 @@ | |||
class="drag-and-drop-handle" | |||
:disabled="isLastSection" | |||
:aria-label="$tc('global.button.move')" | |||
@keydown.down="$emit('moveDown', itemKey)" | |||
@keydown.up="$emit('moveUp', itemKey)" | |||
@keydown.down="$emit('move-down', itemKey)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manuelmeister
Should it be possible to move the storyboard entries here around with the keyboard?
how do i test this?
frontend/src/App.vue
Outdated
@@ -42,7 +42,7 @@ export default { | |||
} | |||
} | |||
}, | |||
destroyed() { | |||
unmounted() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to vue2 docs, there are no lifecycle hooks unmounted
or beforeUnmount
. Did you check if this code is still called?
https://v2.vuejs.org/v2/guide/instance#Lifecycle-Diagram
https://v2.vuejs.org/v2/api/#Options-Lifecycle-Hooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i reverted that change.
They were not called
@@ -20,6 +20,7 @@ Displays a field as a date picker (can be used with v-model) | |||
> | |||
<template #default="picker"> | |||
<v-date-picker | |||
:picker-date="pickerMonth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the .sync modifier not needed anymore?
(same question for the other places, where the .sync modifier was removed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In vue3 there's a replacement for multiple 2-way-binding properties (argument for v-model):
https://v3-migration.vuejs.org/breaking-changes/v-model
But I guess this is not working in vue2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember vaguely that i had some problems with the .sync modifier.
But i could not reproduce it, so i added the .sync modifier, but changed the attribute order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment below, looks good to me 👍
Turn off the following rules for now: "vue/no-deprecated-dollar-scopedslots-api": "off", "vue/no-deprecated-slot-attribute": "off", "vue/no-deprecated-slot-scope-attribute": "off", because i could not get the new syntax to work. That we are ready for vue3 as soon as the calendar works. Issue: ecamp#5121
7b2788c
to
8507f39
Compare
More rule applications were here: #5122 |
Turn off the following rules for now:
"vue/no-deprecated-dollar-scopedslots-api": "off",
"vue/no-deprecated-slot-attribute": "off",
"vue/no-deprecated-slot-scope-attribute": "off",
because i could not get the new syntax to work.
That we are ready for vue3 as soon as the calendar works. Issue: #5121