Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend add tests for slot forwarding #5171

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented May 12, 2024

frontend: add tests for slot forwarding

That we have tests when we turn the following rules on:
"vue/no-deprecated-dollar-scopedslots-api": "off",
"vue/no-deprecated-slot-attribute": "off",
"vue/no-deprecated-slot-scope-attribute": "off",

Issue: #5121

Related to: #5170,

That they are readable again.
With everything on one line, they are not readable.
Also add the required attribute value to ENumberField.spec.js
That we have tests when we turn the following rules on:
"vue/no-deprecated-dollar-scopedslots-api": "off",
"vue/no-deprecated-slot-attribute": "off",
"vue/no-deprecated-slot-scope-attribute": "off",

Issue: ecamp#5121

Related to: ecamp#5170, ecamp#5122
@simfeld simfeld added this pull request to the merge queue Jun 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 2, 2024
@usu usu added this pull request to the merge queue Jun 2, 2024
Merged via the queue into ecamp:devel with commit c5d6009 Jun 2, 2024
32 checks passed
@BacLuc BacLuc deleted the frontend-add-tests-for-slot-forwarding branch June 2, 2024 19:27
@BacLuc BacLuc mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants