-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: add vue/vue3-recommended rules #5122
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
<template #[name]> | ||
<slot v-for="(_, name) in $slots" :name="name" /> | ||
</template> | ||
<template v-for="(_, name) in $slots" #[name]="slotData"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the same as before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, its what the linter rule proposes, which is 💩
Now i tried another way, which also did not yet work.
With the new syntax, it seems difficult to pass all slots all all slots with slotData.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BacLuc I think I still don't fully understand the scoping. What is the difference between the <slot v-for>
and <template v-for="$scopedSlots">
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this will only work in the future with vue3?
https://github.com/vuejs/rfcs/blob/master/active-rfcs/0006-slots-unification.md#adoption-strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me neither.
That's why i now put a step in between with #5170
where i do the other parts i understood.
3386dcf
to
d531e31
Compare
That they are readable again. With everything on one line, they are not readable. Also add the required attribute value to ENumberField.spec.js
The tests in the commit before show that they did not work.
That we are ready for vue3 as soon as the calendar works. Issue: ecamp#5121
d531e31
to
8a2ddb8
Compare
That we have tests when we turn the following rules on: "vue/no-deprecated-dollar-scopedslots-api": "off", "vue/no-deprecated-slot-attribute": "off", "vue/no-deprecated-slot-scope-attribute": "off", Issue: ecamp#5121 Related to: ecamp#5170, ecamp#5122
That we are ready for vue3 as soon as the calendar works.
Issue: #5121