Skip to content

Conversation

@0nko
Copy link
Member

@0nko 0nko commented Dec 17, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1212373034728509?focus=true

Description

This PR adds strings that need to be translated.

Steps to test this PR

  • All CI checks are green

Note

Adds localized Fire Dialog/data clearing strings across many locales and updates layout/code to use new keys, including a new "nothing to delete" message.

  • Localization:
    • Add Fire Dialog and data-clearing strings (titles, options, descriptions, plurals) in values/strings.xml and multiple locales (bg, cs, da, de, el, es, et, fi, fr, hr, hu, it, lt, lv, nb, nl, pl, pt, ro, ru, sk, sl, sv, tr).
    • Remove hardcoded English Fire Dialog strings from values/donottranslate.xml.
  • UI updates:
    • In sheet_fire_clear_data_granular.xml, switch tabsOption and dataOption primary texts to dataClearingOptionTabs and dataClearingOptionData; update Duck AI label to dataClearingDuckAiChats.
  • Logic:
    • In GranularFireDialog.kt, when no sites, use fireDialogOptionDescriptionNothingToDelete instead of the previous "no sites" string; otherwise unchanged behavior.

Written by Cursor Bugbot for commit 082d9fb. This will update automatically on new commits. Configure here.

Copy link
Member Author

0nko commented Dec 17, 2025

@0nko 0nko mentioned this pull request Dec 17, 2025
1 task
@0nko 0nko changed the base branch from feature/ondrej/fire-dialog-bottom-sheet to graphite-base/7383 December 18, 2025 12:22
@0nko 0nko force-pushed the graphite-base/7383 branch from fd2d97e to 1aba857 Compare December 18, 2025 12:24
@0nko 0nko changed the base branch from graphite-base/7383 to feature/ondrej/fire-dialog-bottom-sheet December 18, 2025 12:24
@0nko 0nko force-pushed the feature/ondrej/fire-dialog-bottom-sheet branch from 1aba857 to 4ad8d08 Compare December 18, 2025 13:05
0nko and others added 3 commits December 18, 2025 14:15
Translate strings to values-es
Translate strings to values-ro
Translate strings to values-tr
Translate strings to values-sk
Translate strings to values-ru
Translate strings to values-et
Translate strings to values-it
Translate strings to values-pl
Translate strings to values-lv
Translate strings to values-fi
Translate strings to values-sl
Translate strings to values-nl
Translate strings to values-hr
Translate strings to values-hu
Translate strings to values-nb
Translate strings to values-sv
Translate strings to values-da
Translate strings to values-el
Translate strings to values-fr
Translate strings to values-lt
Translate strings to values-pt
Translate strings to values-cs
@0nko 0nko force-pushed the feature/ondrej/fire-dialog-translations branch from e0e4413 to 082d9fb Compare December 18, 2025 13:16
Base automatically changed from feature/ondrej/fire-dialog-bottom-sheet to develop December 18, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants