Fire Dialog: New feature flag #7295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
force-pushed
the
feature/ondrej/fire-dialog-feature-flag
branch
from
0638330 to
78de185
Compare
CDRussell
approved these changes
Dec 10, 2025
| * If the remote feature is not present defaults to `false` | ||
| */ | ||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) | ||
| fun newDataClearingOptions(): Toggle |
Member
There was a problem hiding this comment.
nit: is the name set in stone? having new in there is going to lose meaning very quickly. would suggest something more meaningful, even if it's planned to be temporary, like moreGranularDataClearingOptions ?
Member
Author
There was a problem hiding this comment.
That's a good idea, I'll use your suggestion. Thanks.
0nko
force-pushed
the
feature/ondrej/fire-dialog-feature-flag
branch
from
78de185 to
c6a0422
Compare
0nko
force-pushed
the
feature/ondrej/fire-dialog-data-storage
branch
from
d2c0980 to
b4a869f
Compare
Base automatically changed from
feature/ondrej/fire-dialog-data-storage
to
develop
December 11, 2025 10:33
0nko
force-pushed
the
feature/ondrej/fire-dialog-feature-flag
branch
from
4b0132a to
717cf32
Compare
This was referenced Dec 14, 2025
cursor bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1212237610087258?focus=true ### Description This PR just adds a new feature flag that will be used in subsequent PRs. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds `moreGranularDataClearingOptions` feature flag (default false) to `AndroidBrowserConfigFeature` for fire dialog/data clearing options. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 717cf32. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1212237610087258?focus=true
Description
This PR just adds a new feature flag that will be used in subsequent PRs.
Note
Adds
moreGranularDataClearingOptionsfeature flag (default false) toAndroidBrowserConfigFeaturefor fire dialog/data clearing options.Written by Cursor Bugbot for commit 717cf32. This will update automatically on new commits. Configure here.