-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fire Dialog: Granular fire bottom sheet #7359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8f77f12 to
90c83b6
Compare
app/src/main/java/com/duckduckgo/app/global/view/GranularFireDialogViewModel.kt
Show resolved
Hide resolved
90c83b6 to
be6aad9
Compare
app/src/main/java/com/duckduckgo/app/global/view/GranularFireDialogViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/global/view/GranularFireDialogViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/duckduckgo/app/global/view/GranularFireDialogViewModelTest.kt
Show resolved
Hide resolved
|
@0nko, flagging some discrepencies between testing steps expectations and what I see:
|
|
There are some failing checks, but overall works well and looks good to me! 👍 |
be6aad9 to
3e4ca6f
Compare
9a4ca65 to
920fef0
Compare
3e4ca6f to
75d9559
Compare
920fef0 to
86ce114
Compare
fa87264 to
fd2d97e
Compare
86ce114 to
1a61594
Compare
1aba857 to
4ad8d08
Compare

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1212229354973651?focus=true
Description
This PR adds a new granular fire bottom sheets, which shows the new granular option toggles allowing to select what data to clear.
Steps to test this PR
Feature flag disabled
For the following test steps, make sure you enable the
moreGranularDataClearingOptionsflag in the developer settings!Tab Count Display
Data/History Count Display
With History Enabled:
With History Disabled:
With no History:
Duck.ai Chats Option Visibility
When DuckAI was never opened:
When Duck.ai was opened before:
Feature 6: Selective Data Clearing
Tabs Only:
Data Only:
Duck.ai Chats Only:
Choice Preservation
Other Launch Points
UI changes
Note
Adds a fragment-based Fire dialog with granular clearing options (Tabs/Data/Duck.ai) selected via feature flag, refactors legacy dialog, updates activities to use it, and adds resources and tests.
FireDialoginterface andFireDialogProviderImplthat picksGranularFireDialogorLegacyFireDialogviamoreGranularDataClearingOptions.BottomSheetDialogFragmentwith fragment result events (onShow,onCancel,onClearStarted).GranularFireDialogand layoutsheet_fire_clear_data_granular.xmlwith toggles forTabs,Cookies and Site Data, andDuck.ai Chats.GranularFireDialogViewModelhandling option state, history/site counts, Duck.ai visibility, pixels, and clearing flow.LegacyFireDialogfragment (parity with old behavior), now emitting events and handling animation/restart.BrowserActivity,FireButtonActivity, andTabSwitcherActivityto create dialogs viafireDialogProvider.createFireDialog()and show withsupportFragmentManager; add event listener inBrowserActivity.WebLocalStorageManagerwith boolean-basedclearWebLocalStorage(shouldClearBrowserData, shouldClearDuckAiData); legacy path now delegates with defaults.DateProviderfor daily pixel timestamping.img_fire_96,rounded_top_corners_bottom_sheet_background,background_large_rounded_surface,ic_cookie_24) and strings/plurals for granular UI.GranularFireDialogViewModelTestcovering state, commands, pixels, and clearing order.Written by Cursor Bugbot for commit d169c4f. This will update automatically on new commits. Configure here.