Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft for high quality processing button, fron Jens. #675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paperdigits
Copy link
Contributor

@paperdigits
Copy link
Contributor Author

I don't see any issues tagged in the darktable repo for this...

Copy link
Contributor

@elstoc elstoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, mostly for future reference since I'll probably copy-edit once it's merged anyway. Key thing though is that the bottom panel screenshot also needs updating for the new icon. IIRC when I did it I increased the DPI (to 150 or something) and the font size (to 15), and increased the size of the side panels, so that the image displayed clearly in the documentation.

Darktable pixelpipes process the modules in slightly different ways, the thumbnail pipe as an example is optimized for speed.

The darkroom pixelpipes for the main canvas and the second monitor try to keep resources within limits by downscaling and by
restricting the processed data to what is actually displayed - in darktable speak this is the "region of interest" (ROI).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these mid-sentence line breaks


Click the ![high quality processing icon](./high-quality-processing/high-quality-processing-icon.png#icon) icon to activate high quality processing in the pixelpipe.

Darktable pixelpipes process the modules in slightly different ways, the thumbnail pipe as an example is optimized for speed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally try to avoid starting sentences with the word "darktable" so that I can maintain the idiosyncratic lowercase form without breaking language. If you can't think of a way to reword the sentence it's fine like this.

The darkroom pixelpipes for the main canvas and the second monitor try to keep resources within limits by downscaling and by
restricting the processed data to what is actually displayed - in darktable speak this is the "region of interest" (ROI).

Yet - for exports we have to process the whole image - likely without downscaling - resulting in much larger processing times
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a double-hyphen -- in markdown for dashes, though I would replace the first one with a comma

@elstoc
Copy link
Contributor

elstoc commented Aug 21, 2024

This documentation is for darktable-org/darktable#15910

@paperdigits paperdigits reopened this Aug 25, 2024
Copy link

This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No activity on this PR label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity No activity on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants