-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft for high quality processing button, fron Jens. #675
Open
paperdigits
wants to merge
1
commit into
master
Choose a base branch
from
hq-processing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+897 Bytes
content/darkroom/darkroom-view-layout/high-quality-processing-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
29 changes: 29 additions & 0 deletions
29
content/module-reference/utility-modules/darkroom/high-quality-processing.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
--- | ||
title: high quality processing | ||
id: hq-processing | ||
applicable-version: 4.8 | ||
tags: | ||
view: darkroom | ||
--- | ||
|
||
Click the ![high quality processing icon](./high-quality-processing/high-quality-processing-icon.png#icon) icon to activate high quality processing in the pixelpipe. | ||
|
||
Darktable pixelpipes process the modules in slightly different ways, the thumbnail pipe as an example is optimized for speed. | ||
|
||
The darkroom pixelpipes for the main canvas and the second monitor try to keep resources within limits by downscaling and by | ||
restricting the processed data to what is actually displayed - in darktable speak this is the "region of interest" (ROI). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove these mid-sentence line breaks |
||
|
||
Yet - for exports we have to process the whole image - likely without downscaling - resulting in much larger processing times | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use a double-hyphen |
||
and possibly visible differences compared to what you have seen in darkroom. | ||
|
||
These differences are mostly very subtle but in some cases they are likely to be observed. | ||
Modules like "diffuse or sharpen" using large radii, "profiled denoise" or "local contrast" are more prone to this problem. | ||
|
||
For the user this usually means: there will be visible and unexpected differences between "what you see in darkroom" and the exported image. | ||
Also there might be visible differences if you zoom in or out. | ||
|
||
To avoid these problems you might activate the high quality processing mode. If toggled on, the darkroom pixelpipes are processed | ||
with all available data so the results are as while exporting in high quality mode. | ||
|
||
Please note, this takes large resources and requires a good OpenCL card and CPU for a responsive user interface especially if you keep changing | ||
any module parameters. |
Binary file added
BIN
+897 Bytes
...ility-modules/darkroom/high-quality-processing/high-quality-processing-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally try to avoid starting sentences with the word "darktable" so that I can maintain the idiosyncratic lowercase form without breaking language. If you can't think of a way to reword the sentence it's fine like this.