Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Docs for high quality processing #252

Closed
jenshannoschwalm opened this issue Jul 30, 2024 · 10 comments
Closed

Adding Docs for high quality processing #252

jenshannoschwalm opened this issue Jul 30, 2024 · 10 comments

Comments

@jenshannoschwalm
Copy link

For some reason i can't open a pr (as i usually do for darktable. So here we go ...

  1. In content/darkroom/darkroom-view-layout.md i suggest to add after the focus-peak stuff
![high-quality-processing-icon](./darkroom-view-layout/high-quality-processing-icon.png#icon) [high quality processing](../module-reference/utility-modules/darkroom/high-quality-processing.md)
: Toggle high quality processing mode.
  1. The icon could be
    high-quality-processing-icon

  2. The description could be like

high-quality-processing.md

@elstoc
Copy link
Contributor

elstoc commented Jul 30, 2024

For some reason i can't open a pr

weird, we have had PRs from noobs recently so no idea what could be causing that

@elstoc
Copy link
Contributor

elstoc commented Jul 30, 2024

This will also need a replacement "bottom panel" screenshot for https://docs.darktable.org/usermanual/4.6/en/darkroom/darkroom-view-layout/ as well please. Note that I hacked around with DPI and stuff in darktable to make that image more readable, and it would be good to get another with similar dimensions. This was all before I got my 1440p screen as well so no idea how to reproduce it now. We should probably have a more consistent way to take screenshots

@paperdigits
Copy link
Contributor

Is this supposed to be on dtdocs?

@jenshannoschwalm
Copy link
Author

Is this supposed to be on dtdocs?

Yes :-)

@paperdigits
Copy link
Contributor

If you made the change in the dtdocs repo and tried to open a PR against this repo, it'd make sense that it didn't work @jenshannoschwalm 🗡️

This is for the website, dtorg.

@jenshannoschwalm
Copy link
Author

Arrrg! Thanks for hinting...

@paperdigits
Copy link
Contributor

I can make this a PR on the dtdocs repo if you'd like.

@elstoc
Copy link
Contributor

elstoc commented Aug 16, 2024

lol I didn't even notice this was on the dtorg repo

@jenshannoschwalm
Copy link
Author

I can make this a PR on the dtdocs repo if you'd like.

I would love that !

@paperdigits
Copy link
Contributor

Closing, I opened a PR at darktable-org/dtdocs#675

Thanks @jenshannoschwalm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants