-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pythonic resources] Partial config support for resources #12870
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
83041e6
to
88bc6a6
Compare
88bc6a6
to
46c8b6d
Compare
Deploy preview for dagster ready! Preview available at https://dagster-lpqab6n0y-elementl.vercel.app Direct link to changed pages: |
46c8b6d
to
87305ba
Compare
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 87305ba. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From brief perusal I agree with your assessment in the PR summary. We should wait until after the branch cut to merge this and release in a subsequent dot release. Let's focus on core docs and content until then.
a06b828
to
eb4c02f
Compare
68ad4e6
to
929c237
Compare
cb46b14
to
3844b89
Compare
Reviving this PR based on user request - I think this functionality is useful enough to warrant trying to get it in. Thankfully most of the groundwork was already in our existing |
python_modules/dagster/dagster/_config/pythonic_config/conversion_utils.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_config/pythonic_config/conversion_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall makes sense. Let's try the suggestions on for size and then spin again and then merge.
6d9b416
to
36f29ca
Compare
36f29ca
to
12bb6c9
Compare
Hello folks, Has there been any movement on this? I'm facing some issues with |
12bb6c9
to
12cf734
Compare
996761b
to
6423132
Compare
Summary
(Marking this as ready to review, but this should probably bake a bit longer, I'm a bit hesitant to merge a late PR like this).
Introduces the ability to partially configure a
ConfigurableResource
. The remaining config must then be specified at runtime.For example:
In this case,
bar_str
must be specified at runtime.Test Plan
Introduced new unit tests.