Top level definitions config is not merged with job level config

[ignaski]

Dagster version

1.3.10

What's the issue?

I am trying to use the .configure_at_launch() feature. The example code at https://docs.dagster.io/concepts/resources#configuring-resources-at-launch-time works, however if config is added at the job level, then the code location fails to build with an error:

dagster._core.errors.DagsterInvalidConfigError: Error in config when building job 'my_job' 
    Error 1: Missing required config entry "resources" at the root. Sample config for missing entry: {'resources': {'db_conn': {'config': {'table': '...'}}}}

What did you expect to happen?

I expect it not to ask for the default config, because the resource is defined to be configured at launch

How to reproduce?

The code which I used to reproduce the error

from dagster import ConfigurableResource, Definitions, asset, job, op


class DatabaseResource(ConfigurableResource):
    table: str

    def read(self):
        pass


@op
def data_from_database(db_conn: DatabaseResource):
    return db_conn.read()


@job(config={"execution": {
    "config": {
        "multiprocess": {
            "max_concurrent": 10,
        }
    },
}})
def my_job():
    data_from_database()


defs = Definitions(
    jobs=[my_job],
    resources={"db_conn": DatabaseResource.configure_at_launch()},
)

Deployment type

Local

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

[garethbrickman]

This will potentially fix: #12870