Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pythonic config][alternate] properly propagate default values set at the top level for nested config classes #27209

Open
wants to merge 1 commit into
base: benpankow/partial-support
Choose a base branch
from

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Jan 17, 2025

Summary

Alternate implementation of #27206 which relies on the partial config utilities from #12870

Ensures that default values on Pythonic Config get properly propagated to inner Config classes, e.g.

class ANestedOpConfig(Config):
    an_int: int = 1
    a_bool: bool = True

class AnOpConfig(Config):
    a_string: str = "foo"
    a_nested: ANestedOpConfig = ANestedOpConfig(an_int=5)

Test Plan

New unit test; todo add a few more

@benpankow
Copy link
Member Author

benpankow commented Jan 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant