Introducing the FileUploadNormalizer #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
force-pushed
the
feature/file-upload-normalizer
branch
from
7898019 to
e1d09c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm extracting this from the NC2 because I also need it in
mp_formssoon.The problem is that Contao's file uploads in the form generator (
Form.php) accesses file uploads from the widget itself and there is no defined API. The built-in upload form field generates a typical PHP upload array. Fineuploader returns a UUID but only if you enabled storing the upload otherwise it's different. Then there are other form fields as well. Some return multiple values, others just one. It's a mess.The
FileUploadNormalizeris my answer to this problem until we have a nicer API in Contao. It supports PHP native uploads, UUIDs and regular paths and arrays of all of that.