Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/mime ^5.4 / Unlock contao 4.13 again #224

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

zoglo
Copy link
Contributor

@zoglo zoglo commented Jul 3, 2024

Description

TL;DR:
Contao Haste in 5.2 is not installable on Contao 4.13


#221 introduced symfony/mime as a dependency, however, the minimum requirements were set to ^6.0 || ^7.0.

Contao 4.13 needs symfony/mime in ^5.4.

I've installed the change on a 4.13 with symfony/mime ^5.4 installed and did run the tests:
image

There is also no BC changes in the MimeTypeGuesser:

Changelog:
https://github.com/symfony/mime/blob/6.4/CHANGELOG.md

@zoglo zoglo changed the title Allow "symfony/mime": "^5.4 / Unlock contao 4.13 Allow symfony/mime ^5.4 / Unlock contao 4.13 again Jul 3, 2024
@qzminski qzminski merged commit 8a9fda4 into codefog:main Jul 3, 2024
@qzminski
Copy link
Member

qzminski commented Jul 3, 2024

Thanks, released as 5.2.3.

@zoglo zoglo deleted the bugfix/unlock-symfony-mime-5-4 branch July 3, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants