Extracted the FileUploadNormalizer service #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Util/FileUploadNormalizer.php # tests/Util/FileUploadNormalizerTest.php
|
@Toflar Meaning: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't want to introduce BC here because that service is very unlikely to have been used by third party bundles (and even if they did, that was never intended). I've moved it to haste in codefog/contao-haste#221 where it's better suited and also used by
mp_formsnow.If you stumble over this PR and you actually did use it (again, you were not supposed to and I won't provide a BC layer), you can fix your code very easily: require
^5.2ofcodefog/contao-hasteand useCodefog\HasteBundle\FileUploadNormalizerinstead ofTerminal42\NotificationCenterBundle\Util\FileUploadNormalizer.