Kp pytools to warptools pd 2186 #1026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remember to squash merge! |
There was a problem hiding this comment.
Hey @kevinpalis, would you mind making a couple of doc updates to go along with these changes? If you have any questions please let me know. Thanks so much!
|
Remember to squash merge! |
|
Remember to squash merge! |
|
Remember to squash merge! |
|
Remember to squash merge! |
|
@kevinpalis Thanks for making those doc updates! |
|
Remember to squash merge! |
|
Remember to squash merge! |
|
Remember to squash merge! |
|
Remember to squash merge! |
|
Remember to squash merge! |
|
Remember to squash merge! |
…ries that just won't work with a more recent python container
|
Remember to squash merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already moved the custom python scripts and the docker file for the pytools image into warp-tools. We do not want to have duplicate code.
This PR will remove all usage of pytools in WARP and replace them with the latest warp-tools image that is semantically versioned (ie. not a test container). This also changes the path of the scripts in the container so a minor change to command calls is necessary.
Checklist
If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.