Skip to content

Solari: Fix MIS not using consistent PDF measures#24671

Open
JMS55 wants to merge 2 commits into
bevyengine:mainfrom
JMS55:solari7-pdf-fix
Open

Solari: Fix MIS not using consistent PDF measures#24671
JMS55 wants to merge 2 commits into
bevyengine:mainfrom
JMS55:solari7-pdf-fix

Conversation

@JMS55

@JMS55 JMS55 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Objective

  • MIS between emissive and NEE light samples use area measure for the emissive sample PDF, but solid angle measure for the NEE sample PDF.

Solution

  • Consistently use solid angle PDFs for MIS
  • Also move isinf to sampling.wgsl for consistency

@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jun 19, 2026
@JMS55 JMS55 added this to the 0.20 milestone Jun 19, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jun 19, 2026

@stuartparmenter stuartparmenter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The math here seems right, but a few extra comments would probably be helpful in the future -- namely the difference between the two PDFs and the NdotV/ray_distance params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

2 participants