Skip to content

FreeCam: change walk_speed scaling to avoid sticking to zero/negative speeds #21486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −4
Open

FreeCam: change walk_speed scaling to avoid sticking to zero/negative speeds #21486

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8286da7
change walk_speed scaling to avoid sticking to zero/negative speeds
janis-bhm Oct 9, 2025
c74cedc
simplify walk_speed logic as suggested by iquick
janis-bhm Oct 10, 2025
9af8913
move run_speed outside of amount check in case walk_speed was changed…
janis-bhm Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/bevy_camera_controller/src/free_cam.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,16 +186,17 @@ pub fn run_freecam_controller(
return;
}

let mut scroll = 0.0;

let amount = match accumulated_mouse_scroll.unit {
MouseScrollUnit::Line => accumulated_mouse_scroll.delta.y,
MouseScrollUnit::Pixel => {
accumulated_mouse_scroll.delta.y / MouseScrollUnit::SCROLL_UNIT_CONVERSION_FACTOR
}
};
scroll += amount;
controller.walk_speed += scroll * controller.scroll_factor * controller.walk_speed;

if amount != 0.0 {
Copy link
Contributor

@IQuick143 IQuick143 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this if is kind of redundant, but that's a nitpick.

let factor = bevy_math::ops::exp(controller.scroll_factor * amount);
controller.walk_speed = (controller.walk_speed * factor).clamp(0.0, f32::MAX);
}
controller.run_speed = controller.walk_speed * 3.0;

// Handle key input
Expand Down