-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Modifying the readme in example to address the wayland default #21411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modifying the readme in example to address the wayland default #21411
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
You'll need to fix CI, but this seems helpful and the wording is good. |
This might not be a good idea because when i tried to run other examples they failed to compile because other default features were required |
Related to #21158; I think this needs to be blocked on that. |
There is one problem in the current condition. The only way i can run the examples is to manually comment out the wayland default in the cargo toml. Currently there is no way to disable only one default. |
I jumped to a wayland system now |
I am new to bevy, so I just cloned the repository and did a cargo build. That gave me the error:
then I discovered that my system runs on x11, but when i ran the example:
I still got the error.
This PR is trying to fix this.
Objective
Since engine runs on wayland by default, the defaults need to be disabled for running on x11.
Solution
The first example of
cargo run
in example/README.md needs to specify how to do this. Hence a new example is added.Testing
I did run the cargo my self and the newly added example works on my system, the command being: