Skip to content

Use RenderStartup in bevy_sprite. #20147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2025
Merged

Use RenderStartup in bevy_sprite. #20147

merged 6 commits into from
Jul 15, 2025

Conversation

andriyDev
Copy link
Contributor

Objective

Solution

  • Convert FromWorld implementations into systems.
  • Move any resource "manipulation" from Plugin::finish to systems.
  • Add after dependencies to any uses of these resources (basically all SpritePipeline).

Testing

  • Ran the sprite, and mesh2d_manual example and it worked.

@andriyDev andriyDev added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 15, 2025
@andriyDev andriyDev requested a review from atlv24 July 15, 2025 00:23
@andriyDev andriyDev requested a review from IceSentry July 15, 2025 00:23
IceSentry
IceSentry reviewed Jul 15, 2025
View reviewed changes
crates/bevy_sprite/src/mesh2d/mesh.rs
}
);
// Forget the handle so we don't have to store it anywhere, and we keep the embedded asset
// loaded. Note: This is what happens in `load_shader_library` internally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really have an alternative to this macro that works in this RenderStartup context. This isn't a blocker, but this isn't ideal either.

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 15, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 15, 2025
Merged via the queue into bevyengine:main with commit 2824bd5 Jul 15, 2025
34 checks passed
@andriyDev andriyDev deleted the startup-sprite branch July 15, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@atlv24 atlv24 Awaiting requested review from atlv24

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriyDev @alice-i-cecile @IceSentry