Mitigate Tracy dep version woes #20109
Open
+11
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Turns out, Tracy dep (in)compatibilities can be a headache. Here was my experience following the Profiling Tracy documentation:
I ran into this error when I attempted to connect to my bevy client:
Attempting to find where the version incompatibility stemmed, I found these tracy dep versions and a link to the compatibility table in the source:
bevy/crates/bevy_log/Cargo.toml
Lines 32 to 35 in 1525dff
This led me to believe I needed Tracy
0.11.1
, to match thetracy-client
version0.18.0
.This was confusing because
0.11.1
is the version I already had installed (by runningbrew install tracy
), and latest Tracy version currently available onbrew
.It turned out that Cargo was eagerly pulling
tracy-client
0.18.2
instead of0.18.0
, making the Tracy version I needed actually0.12.2
. At the time of writing,0.12.2
is not published onbrew
.Solution
I've pinned the Tracy deps, and mentioned in the comment which Tracy version Bevy is compatible with.
I've also added some notes to Profiling Tracy documentation to explain
brew
.Testing
Did you test these changes? If so, how?
I ran Tracy locally.
Are there any parts that need more testing?
I don't think so.
How can other people (reviewers) test your changes? Is there anything specific they need to know?
Follow instructions to run Tracy
If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
Tested MacOS. I think change should be OS agnostic.